Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pull request description mentions a breaking change (renaming
Sm120BlockScaledDenseGemmKerneltoSm120B12xBlockScaledDenseGemmKerneland removing the old name). According to semantic versioning principles, a patch release (0.6.9 to 0.6.10) should not introduce breaking changes, as this can disrupt downstream users who rely on patch updates for bug fixes without API breakage. Consider either adding a deprecation alias for the old class name inflashinfer/gemm/__init__.pyto maintain backward compatibility, or bumping the version to a minor version (e.g.,0.7.0) instead of a patch version.