feat: update trtllm-gen bmm cubins#3045
feat: update trtllm-gen bmm cubins#3045samuellees wants to merge 2 commits intoflashinfer-ai:mainfrom
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughUpdated the remote artifact subdirectory identifier and its SHA256 checksum for the TRTLLM batched_gemm (BMM) artifact constants used to construct download paths and checksum verification. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
/bot run |
There was a problem hiding this comment.
Code Review
This pull request updates the artifact path and checksum for TRTLLM_GEN_BMM in flashinfer/artifacts.py. A review comment suggests adding a trailing slash to the updated path to maintain consistency with other artifact definitions in the class.
|
@flashinfer-bot rerun |
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Fix #2671
Thanks a lot for @bkryu @nekorobov @ David Clark
📌 Description
Update TRT-LLM Gen Batched GEMM Cubins for perf imporvement
🔍 Related Issues
#2671
🚀 Pull Request Checklist
Thank you for contributing to FlashInfer! Before we review your pull request, please make sure the following items are complete.
✅ Pre-commit Checks
pre-commitby runningpip install pre-commit(or used your preferred method).pre-commit install.pre-commit run --all-filesand fixed any reported issues.🧪 Tests
unittest, etc.).Reviewer Notes
Summary by CodeRabbit