Skip to content

ci: remove 1gpu label from H100 runner selector#2946

Merged
yongwww merged 2 commits intoflashinfer-ai:mainfrom
yongwww:ci_upd_h100
Apr 2, 2026
Merged

ci: remove 1gpu label from H100 runner selector#2946
yongwww merged 2 commits intoflashinfer-ai:mainfrom
yongwww:ci_upd_h100

Conversation

@yongwww
Copy link
Copy Markdown
Member

@yongwww yongwww commented Apr 1, 2026

📌 Description

Relax the runs-on to allow the multi-gpu runner to be used.

🔍 Related Issues

🚀 Pull Request Checklist

Thank you for contributing to FlashInfer! Before we review your pull request, please make sure the following items are complete.

✅ Pre-commit Checks

  • I have installed pre-commit by running pip install pre-commit (or used your preferred method).
  • I have installed the hooks with pre-commit install.
  • I have run the hooks manually with pre-commit run --all-files and fixed any reported issues.

If you are unsure about how to set up pre-commit, see the pre-commit documentation.

🧪 Tests

  • Tests have been added or updated as needed.
  • All tests are passing (unittest, etc.).

Reviewer Notes

Summary by CodeRabbit

  • Chores
    • Broadened CI runner selection for GPU test jobs to allow a wider set of matching runners.
  • Tests
    • Improved GPU test run logging with per-test launch and completion messages, progress counts, and GPU assignment info for clearer real-time test progress.

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Note

Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Apr 1, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: c29dd488-5ba2-4880-b574-c34277d561fa

📥 Commits

Reviewing files that changed from the base of the PR and between 4ec0417 and e771386.

📒 Files selected for processing (1)
  • scripts/test_utils.sh

📝 Walkthrough

Walkthrough

Removed the 1gpu label from the gpu-tests-h100 job's runner selection in the GitHub Actions workflow and added per-test progress tracking and logging to run_tests_parallel() in scripts/test_utils.sh (records finished tests, launched test logs, and prints incremental completion messages).

Changes

Cohort / File(s) Summary
CI Runner Configuration
.github/workflows/pr-test.yml
Removed the 1gpu label from runs-on for the gpu-tests-h100 job (still targets self-hosted, linux, x64, gpu, h100).
Test orchestration script
scripts/test_utils.sh
Enhanced run_tests_parallel() with a completed counter, mapping of PIDs to test filenames, per-test launch logs ([i/total] Launching: ... on GPU ...) and incremental [completed/total completed] progress messages while waiting for jobs to finish.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

Suggested labels

run-ci

Suggested reviewers

  • yzh119
  • nvmbreughe
  • jimmyzho
  • kahyunnam
  • dierksen

Poem

🐰 I hopped through CI with nimble feet,
Dropped a label light and fleet.
Tests now sing, each finish logged,
Progress ticks — no fog, no clog.
H100 hums, the run is sweet. 🥕✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately summarizes the main change: removing the 1gpu label from the H100 runner selector in CI configuration.
Description check ✅ Passed The description provides the main context (relax runs-on to allow multi-gpu runner) and follows the template structure with all key sections present, though test checklist items remain unchecked.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@yongwww yongwww merged commit 34b6550 into flashinfer-ai:main Apr 2, 2026
53 of 78 checks passed
@yongwww yongwww deleted the ci_upd_h100 branch April 2, 2026 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants