Planned CODEOWNERS & review/approval approach changes

[aleozlx]

📌 Description

Rationale

1. Focus on PR level review/approval routing
2. Cover important directories only, to simplify & streamline

• Rest is covered by catch-all rule
• Focus on long-term code owners

3. Use GitHub native functions as much as possible to reduce maintenance

🔍 Related Issues

Closing some older mitigation proposals

#2542
#2718

🚀 Pull Request Checklist

Thank you for contributing to FlashInfer! Before we review your pull request, please make sure the following items are complete.

✅ Pre-commit Checks

• I have installed pre-commit by running pip install pre-commit (or used your preferred method).
• I have installed the hooks with pre-commit install.
• I have run the hooks manually with pre-commit run --all-files and fixed any reported issues.

If you are unsure about how to set up pre-commit, see the pre-commit documentation.

🧪 Tests

• Tests have been added or updated as needed.
• All tests are passing (unittest, etc.).

Reviewer Notes

Before approving, we need to fix errors flagged by GitHub in the diff view on this PR

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request overhauls the repository's code ownership and review process. It transitions from an automated, detailed CODEOWNERS system to a simplified, manually managed one that focuses on high-level, team-based ownership for critical modules. This change aims to streamline the review workflow, reduce maintenance overhead, and leverage GitHub's native features more effectively.

Highlights

• CODEOWNERS Simplification: The CODEOWNERS file has been completely refactored to simplify review assignments, moving from a granular, automatically generated list to a manually maintained, team-based approach.
• Automated CODEOWNERS Generation Removed: The scripts and configuration files (scripts/codeowner_analyzer.py, scripts/authorized_codeowner.txt, scripts/codeowner_overrides.json) previously used for automatic CODEOWNERS generation have been removed.
• Team-Based Ownership: Ownership is now primarily assigned to GitHub teams (e.g., @flashinfer-ai/attention-owners) for specific, important directories, with a catch-all rule for core maintainers.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Ignored Files

• Ignored by pattern: .github/workflows/** (1)
  • .github/workflows/update-codeowners.yml

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request refactors the CODEOWNERS file, moving from a complex, auto-generated system to a simpler, manually maintained one. This is a great improvement for clarity and maintainability. The new structure is well-organized by feature areas. I've found a minor formatting issue where the alignment of owners is inconsistent, making the file harder to read. I've added a specific comment with a suggestion to fix this. Overall, this is a positive change that simplifies the code ownership process.

[gemini-code-assist]

The alignment of owners in this section (and others in the file) is inconsistent, which harms readability and maintainability. It's a good practice to align the owners for clarity. This might also help spot any subtle errors, as mentioned in the PR description.

I suggest aligning all owner declarations in this file. Here's a suggested alignment for the GDN section:

benchmarks/gdn/                         @flashinfer-ai/misc-op-owners @kahyunnam
csrc/gdn_prefill_launcher.cu            @flashinfer-ai/misc-op-owners @kahyunnam
csrc/gdn_prefill_sm90_kernel_inst.jinja @flashinfer-ai/misc-op-owners @kahyunnam
flashinfer/gdn_decode.py                @flashinfer-ai/misc-op-owners @kahyunnam
flashinfer/gdn_kernels/                 @flashinfer-ai/misc-op-owners @kahyunnam
flashinfer/gdn_prefill.py               @flashinfer-ai/misc-op-owners @kahyunnam
flashinfer/jit/gdn.py                   @flashinfer-ai/misc-op-owners @kahyunnam
tests/gdn/                              @flashinfer-ai/misc-op-owners @kahyunnam

[coderabbitai]

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 16421eac-7d29-448d-825c-1ddadf055bc5

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

📝 Coding Plan

• Generate coding plan for human review comments

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}