Skip to content
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions flashinfer/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -107,10 +107,12 @@
from .gemm import tgv_gemm_sm100 as tgv_gemm_sm100
from .mla import BatchMLAPagedAttentionWrapper as BatchMLAPagedAttentionWrapper
from .norm import fused_add_rmsnorm as fused_add_rmsnorm
from .norm import fused_add_rmsnorm_quant as fused_add_rmsnorm_quant
from .norm import layernorm as layernorm
from .norm import gemma_fused_add_rmsnorm as gemma_fused_add_rmsnorm
from .norm import gemma_rmsnorm as gemma_rmsnorm
from .norm import rmsnorm as rmsnorm
from .norm import rmsnorm_quant as rmsnorm_quant
Comment on lines 109 to +115
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For better code readability and consistency, it's a good practice to sort imports alphabetically and remove redundant aliases (e.g., import foo as foo). This block of imports from .norm could be reordered and cleaned up to follow PEP 8 guidelines.

Suggested change
from .norm import fused_add_rmsnorm as fused_add_rmsnorm
from .norm import fused_add_rmsnorm_quant as fused_add_rmsnorm_quant
from .norm import layernorm as layernorm
from .norm import gemma_fused_add_rmsnorm as gemma_fused_add_rmsnorm
from .norm import gemma_rmsnorm as gemma_rmsnorm
from .norm import rmsnorm as rmsnorm
from .norm import rmsnorm_quant as rmsnorm_quant
from .norm import fused_add_rmsnorm
from .norm import fused_add_rmsnorm_quant
from .norm import gemma_fused_add_rmsnorm
from .norm import gemma_rmsnorm
from .norm import layernorm
from .norm import rmsnorm
from .norm import rmsnorm_quant
References
  1. PEP 8 recommends that imports are grouped and sorted. Within each group, imports should be sorted alphabetically. (link)


try:
from .norm import rmsnorm_fp4quant as rmsnorm_fp4quant
Expand Down
Loading