Skip to content

Dispatch GQA group size 5, 6, 7 #2684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ahadnagy wants to merge 1 commit into from
Closed

Dispatch GQA group size 5, 6, 7 #2684

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions include/flashinfer/utils.cuh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,6 +134,15 @@
} else if (group_size == 4) { \
constexpr size_t GROUP_SIZE = 4; \
__VA_ARGS__ \
} else if (group_size == 5) { \
constexpr size_t GROUP_SIZE = 5; \
__VA_ARGS__ \
} else if (group_size == 6) { \
constexpr size_t GROUP_SIZE = 6; \
__VA_ARGS__ \
} else if (group_size == 7) { \
constexpr size_t GROUP_SIZE = 7; \
__VA_ARGS__ \
Comment on lines +137 to +145
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot Mar 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The added group sizes are a good extension. However, to ensure correctness, it's crucial to have corresponding test cases. I noticed in tests/attention/test_batch_attention.py that tests for gqa_group_size 5 and 6 are missing. Please add them to ensure full coverage of the new functionality.

Comment on lines +137 to +145
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot Mar 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

While adding more else if conditions works, this chain is getting long. For better readability and maintainability, consider refactoring the DISPATCH_GQA_GROUP_SIZE macro to use a switch statement, similar to how DISPATCH_HEAD_DIM is implemented in this file.

} else if (group_size == 8) { \
constexpr size_t GROUP_SIZE = 8; \
__VA_ARGS__ \
Expand Down