Skip to content

Manual codeowner update for qwen3-next/gdn PR reviews #2652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kahyunnam wants to merge 1 commit into from
Closed

Manual codeowner update for qwen3-next/gdn PR reviews #2652

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .github/CODEOWNERS
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
# Minimum commits threshold: 1

benchmarks/ @bkryu @jiahanc @yzh119 @Anerudhan @kahyunnam
benchmarks/gdn/ @kahyunnam
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai bot Feb 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

🧩 Analysis chain

🏁 Script executed:

cat -n .github/CODEOWNERS

Repository: flashinfer-ai/flashinfer

Length of output: 2925

🏁 Script executed:

#!/bin/bash
# Verify that all GDN-related paths exist in the repository

echo "Checking GDN path existence..."

paths=(
  "benchmarks/gdn"
  "flashinfer/gdn_decode.py"
  "flashinfer/gdn_prefill.py"
  "flashinfer/gdn_kernels"
  "tests/gdn"
)

for path in "${paths[@]}"; do
  if [ -e "$path" ]; then
    echo "✓ $path exists"
  else
    echo "✗ $path does NOT exist"
  fi
done

Repository: flashinfer-ai/flashinfer

Length of output: 250

Remove the non-existent benchmarks/gdn/ path from CODEOWNERS.

While most GDN-related paths exist (flashinfer/gdn_decode.py, flashinfer/gdn_prefill.py, flashinfer/gdn_kernels/, and tests/gdn/), the benchmarks/gdn/ entry on line 7 points to a directory that does not exist in the repository. Remove this entry to avoid confusion.

🤖 Prompt for AI Agents 
Verify each finding against the current code and only fix it if needed.

In @.github/CODEOWNERS at line 7, Remove the nonexistent CODEOWNERS entry
"benchmarks/gdn/ `@kahyunnam`" from the .github/CODEOWNERS file; locate the line
containing the literal path "benchmarks/gdn/" and delete that line so only real
paths (e.g. flashinfer/gdn_* and tests/gdn/) remain, then save the updated
CODEOWNERS.

benchmarks/routines/ @bkryu @nv-yunzheq @Anerudhan @jiahanc @cyx-6
ci/ @cyx-6 @yzh119 @nvmbreughe
ci/scripts/ @cyx-6
Expand All @@ -29,6 +30,9 @@ flashinfer/cudnn/ @Anerudhan @yzh119 @bkryu @cyx-6
flashinfer/cute_dsl/ @aleozlx @bkryu @yzh119 @kaixih @jimmyzho
flashinfer/dsv3_ops/ @nv-yunzheq @jiahanc @nvmbreughe
flashinfer/fused_moe/ @nv-yunzheq @yzh119 @jiahanc @djmmoss @cyx-6
flashinfer/gdn_decode.py @kahyunnam
Copy link
Copy Markdown
Collaborator

@aleozlx aleozlx Feb 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can make a gdn module? and use codeowner_overrides.json mapping

flashinfer/gdn_prefill.py @kahyunnam
flashinfer/gdn_kernels/ @kahyunnam
Comment on lines +33 to +35
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot Feb 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For better maintainability, it's good practice to keep entries in the CODEOWNERS file sorted alphabetically. The flashinfer/gdn_* entries seem to be slightly out of order.

flashinfer/gdn_decode.py @kahyunnam
flashinfer/gdn_kernels/ @kahyunnam
flashinfer/gdn_prefill.py @kahyunnam

flashinfer/gemm/ @bkryu @nvmbreughe @yongwww @jimmyzho
flashinfer/jit/ @yzh119 @jimmyzho @cyx-6 @jiahanc @aleozlx
flashinfer/jit/attention/ @yzh119 @jimmyzho @cyx-6
Expand All @@ -46,3 +50,4 @@ include/flashinfer/gemm/ @ttyio @yongwww @yzh119 @nvmbreughe @aleozlx
include/flashinfer/trtllm/ @yzh119 @jiahanc @aleozlx @joker-eph @IwakuraRein
profiler/ @cyx-6
scripts/ @yzh119 @nvmbreughe @kahyunnam @jimmyzho @dierksen
tests/gdn/ @kahyunnam
Loading