-
Notifications
You must be signed in to change notification settings - Fork 889
fix: add SM121 support to SM120 version guards #2631
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -348,7 +348,8 @@ struct CutlassGemmConfig { | |
| bool enableCudaKernel = false; | ||
| int sm_version = 80; // Use 80 as a catch all for <90 | ||
| bool is_tma_warp_specialized = false; | ||
| bool use_stream_k = false; // SM120: false = DP scheduler (default), true = StreamK scheduler | ||
| bool use_stream_k = | ||
| false; // SM120/SM121: false = DP scheduler (default), true = StreamK scheduler | ||
|
|
||
| CutlassGemmConfig() = default; | ||
|
|
||
|
|
@@ -379,7 +380,7 @@ struct CutlassGemmConfig { | |
| sm_version(100), | ||
| is_tma_warp_specialized(true) {} | ||
|
|
||
| // SM120 constructor with optional StreamK scheduler | ||
| // SM120/SM121 constructor with optional StreamK scheduler | ||
| // use_stream_k: false = DP scheduler (default), true = StreamK scheduler (auto heuristic) | ||
| CutlassGemmConfig(CutlassTileConfigSM120 tile_config_sm120, | ||
| MainloopScheduleType mainloop_schedule, EpilogueScheduleType epilogue_schedule, | ||
|
|
@@ -393,7 +394,7 @@ struct CutlassGemmConfig { | |
| use_stream_k(use_stream_k) {} | ||
|
|
||
| int getTileConfigAsInt() const { | ||
| if (sm_version == 120) return (int)tile_config_sm120; | ||
| if (sm_version == 120 || sm_version == 121) return (int)tile_config_sm120; | ||
| if (sm_version == 110) return (int)tile_config_sm100; | ||
| if (sm_version >= 100) return (int)tile_config_sm100; | ||
| if (sm_version == 90) return (int)tile_config_sm90; | ||
|
|
@@ -413,8 +414,8 @@ struct CutlassGemmConfig { | |
| << "\n\tmainloop sched: " << (int)mainloop_schedule | ||
| << "\n\tepi sched: " << (int)epilogue_schedule | ||
| << "\n\tenable cuda kernel: " << (enableCudaKernel ? "true" : "false"); | ||
| // SM120 specific: StreamK scheduler option | ||
| if (sm_version == 120) { | ||
| // SM120/SM121 specific: StreamK scheduler option | ||
| if (sm_version == 120 || sm_version == 121) { | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
| tactic << "\n\tscheduler: " << (use_stream_k ? "StreamK (auto heuristic)" : "DP (default)"); | ||
| } | ||
| } else if (tile_config_sm80 != flashinfer::gemm::CutlassTileConfig::ChooseWithHeuristic) { | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While this change correctly adds support for SM121, the error message raised on line 3044, which is controlled by the
CUDNN_FP4_MXFP4_SM120_CUDNN_VERSION_ERRORconstant, is now potentially misleading as it only mentions SM120. To avoid confusion for users on SM121 devices, please consider updating the error message to include SM121.