Skip to content

[Bug] Fix spark unit test failures for test_add_rmsnorm_fp4_quant_cute_dsl #2573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kahyunnam merged 2 commits into from
Feb 18, 2026
Merged

[Bug] Fix spark unit test failures for test_add_rmsnorm_fp4_quant_cute_dsl #2573

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7449c12
fix spark unit test failure for test_add_rmsnorm_fp4_quant_cute_dsl
kahyunnam Feb 17, 2026
016ddaf
cluster scoped fence
kahyunnam Feb 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions flashinfer/cute_dsl/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,10 +53,6 @@
add_rmsnorm_fp4quant,
AddRMSNormFP4QuantKernel,
)
from .gated_delta_rule import (
gated_delta_rule,
GatedDeltaRuleKernel,
)

__all__ = [
# Utils (always available)
Expand All @@ -83,7 +79,4 @@
# Add + RMSNorm + FP4 Quantization
"add_rmsnorm_fp4quant",
"AddRMSNormFP4QuantKernel",
# Gated Delta Rule
"gated_delta_rule",
"GatedDeltaRuleKernel",
]
8 changes: 8 additions & 0 deletions flashinfer/cute_dsl/add_rmsnorm_fp4quant.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -536,6 +536,14 @@ def kernel(
if row_in_bounds:
cute.copy(copy_atom_store, tRrO, tRgO, pred=tXpX)

# In cluster mode, Phase 3 reads from mR across the FULL hidden dimension,
# including slices written by other CTAs. We must ensure all CTAs' global
# memory writes are visible before any CTA proceeds to Phase 3.
if cutlass.const_expr(cluster_n > 1):
cute.arch.fence_acq_rel_cluster()
cute.arch.cluster_arrive_relaxed()
cute.arch.cluster_wait()

actual_row_idx = bidx * rows_per_block + row_in_block

# Phase 3: RMSNorm + Quantize
Expand Down
Loading