Skip to content

ci: fix permission errors in release workflow on ci-infra runner#2488

Merged
yongwww merged 2 commits intomainfrom
yongwww/fix_workflow_permission
Feb 5, 2026
Merged

ci: fix permission errors in release workflow on ci-infra runner#2488
yongwww merged 2 commits intomainfrom
yongwww/fix_workflow_permission

Conversation

@yongwww
Copy link
Member

@yongwww yongwww commented Feb 4, 2026

📌 Description

Fix permission errors in release workflows when running on ci-infra runners. The ci-infra runners use rootless Docker, which has different UID namespace mapping

🔍 Related Issues

🚀 Pull Request Checklist

Thank you for contributing to FlashInfer! Before we review your pull request, please make sure the following items are complete.

✅ Pre-commit Checks

  • I have installed pre-commit by running pip install pre-commit (or used your preferred method).
  • I have installed the hooks with pre-commit install.
  • I have run the hooks manually with pre-commit run --all-files and fixed any reported issues.

If you are unsure about how to set up pre-commit, see the pre-commit documentation.

🧪 Tests

  • Tests have been added or updated as needed.
  • All tests are passing (unittest, etc.).

Reviewer Notes

@gemini-code-assist
Copy link
Contributor

Note

Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 4, 2026

📝 Walkthrough

Walkthrough

Removed Docker permission adjustments and user flags from two CI/CD workflow files, simplifying the containerized build setup by eliminating explicit ownership changes and relying on default container user context.

Changes

Cohort / File(s) Summary
CI/CD Workflow Configuration
.github/workflows/nightly-release.yml, .github/workflows/release.yml
Removed chown -R commands for workspace and ci-cache directories and the --user flag from docker run invocations, streamlining container execution by using default user permissions.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Suggested labels

run-ci

Suggested reviewers

  • yzh119

Poem

🐰 A rabbit hops through workflows with glee,
Chown commands fading, now simple and free,
No users to specify, permissions set right,
Docker runs cleaner, the build shines so bright! ✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 inconclusive)
Check name Status Explanation Resolution
Description check ❓ Inconclusive The pull request description provides minimal context. While it mentions fixing permission errors with ci-infra runners and rootless Docker, the description is incomplete and lacks key details about the changes. Expand the description to explain: (1) what specific permission errors occurred, (2) why removing chown commands and the --user flag resolves the issue, (3) any potential side effects or testing performed, and (4) reference the related GitHub issues.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and specifically describes the main change: fixing permission errors in the release workflow on the ci-infra runner, which aligns with the modifications to remove chown and --user flag configurations.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch yongwww/fix_workflow_permission

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@yongwww yongwww marked this pull request as ready for review February 4, 2026 17:23
@yongwww
Copy link
Member Author

yongwww commented Feb 4, 2026

@yongwww
Copy link
Member Author

yongwww commented Feb 5, 2026

I cancelled the pr-test since the change is not related.

Copy link
Collaborator

@bkryu bkryu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yzh119
Copy link
Collaborator

yzh119 commented Feb 5, 2026

The workflow is green with the change: https://github.com/flashinfer-ai/flashinfer/actions/runs/21661685706.

Awesome, does this mean we can move nightly out of flashinfer repo now?

@yongwww
Copy link
Member Author

yongwww commented Feb 5, 2026

The workflow is green with the change: https://github.com/flashinfer-ai/flashinfer/actions/runs/21661685706.

Awesome, does this mean we can move nightly out of flashinfer repo now?

Yes, I think so, it should be quite straightforward


update: we can start to do it once the flashinfer-ai/nightly repo gets created

@yongwww yongwww merged commit cdbb2c3 into main Feb 5, 2026
73 of 93 checks passed
@yongwww yongwww deleted the yongwww/fix_workflow_permission branch February 5, 2026 01:16
raayandhar pushed a commit to raayandhar/flashinfer that referenced this pull request Feb 5, 2026
…shinfer-ai#2488)

<!-- .github/pull_request_template.md -->

## 📌 Description

<!-- What does this PR do? Briefly describe the changes and why they’re
needed. -->

Fix permission errors in release workflows when running on ci-infra
runners. The ci-infra runners use rootless Docker, which has different
UID namespace mapping


## 🔍 Related Issues

<!-- Link any related issues here -->

## 🚀 Pull Request Checklist

Thank you for contributing to FlashInfer! Before we review your pull
request, please make sure the following items are complete.

### ✅ Pre-commit Checks

- [x] I have installed `pre-commit` by running `pip install pre-commit`
(or used your preferred method).
- [x] I have installed the hooks with `pre-commit install`.
- [x] I have run the hooks manually with `pre-commit run --all-files`
and fixed any reported issues.

> If you are unsure about how to set up `pre-commit`, see [the
pre-commit documentation](https://pre-commit.com/).

## 🧪 Tests

- [x] Tests have been added or updated as needed.
- [x] All tests are passing (`unittest`, etc.).

## Reviewer Notes

<!-- Optional: anything you'd like reviewers to focus on, concerns, etc.
-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants