ci: fix permission errors in release workflow on ci-infra runner#2488
ci: fix permission errors in release workflow on ci-infra runner#2488
Conversation
|
Note Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported. |
📝 WalkthroughWalkthroughRemoved Docker permission adjustments and user flags from two CI/CD workflow files, simplifying the containerized build setup by eliminating explicit ownership changes and relying on default container user context. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
The workflow is green with the change: https://github.com/flashinfer-ai/flashinfer/actions/runs/21661685706. |
|
I cancelled the pr-test since the change is not related. |
Awesome, does this mean we can move nightly out of flashinfer repo now? |
Yes, I think so, it should be quite straightforward update: we can start to do it once the flashinfer-ai/nightly repo gets created |
…shinfer-ai#2488) <!-- .github/pull_request_template.md --> ## 📌 Description <!-- What does this PR do? Briefly describe the changes and why they’re needed. --> Fix permission errors in release workflows when running on ci-infra runners. The ci-infra runners use rootless Docker, which has different UID namespace mapping ## 🔍 Related Issues <!-- Link any related issues here --> ## 🚀 Pull Request Checklist Thank you for contributing to FlashInfer! Before we review your pull request, please make sure the following items are complete. ### ✅ Pre-commit Checks - [x] I have installed `pre-commit` by running `pip install pre-commit` (or used your preferred method). - [x] I have installed the hooks with `pre-commit install`. - [x] I have run the hooks manually with `pre-commit run --all-files` and fixed any reported issues. > If you are unsure about how to set up `pre-commit`, see [the pre-commit documentation](https://pre-commit.com/). ## 🧪 Tests - [x] Tests have been added or updated as needed. - [x] All tests are passing (`unittest`, etc.). ## Reviewer Notes <!-- Optional: anything you'd like reviewers to focus on, concerns, etc. -->
📌 Description
Fix permission errors in release workflows when running on ci-infra runners. The ci-infra runners use rootless Docker, which has different UID namespace mapping
🔍 Related Issues
🚀 Pull Request Checklist
Thank you for contributing to FlashInfer! Before we review your pull request, please make sure the following items are complete.
✅ Pre-commit Checks
pre-commitby runningpip install pre-commit(or used your preferred method).pre-commit install.pre-commit run --all-filesand fixed any reported issues.🧪 Tests
unittest, etc.).Reviewer Notes