Skip to content

hotfix: remove uv.lock and add it to .gitignore#2399

Merged
yzh119 merged 1 commit intoflashinfer-ai:mainfrom
yzh119:hotfix-remove-uvlock
Jan 22, 2026
Merged

hotfix: remove uv.lock and add it to .gitignore#2399
yzh119 merged 1 commit intoflashinfer-ai:mainfrom
yzh119:hotfix-remove-uvlock

Conversation

@yzh119
Copy link
Copy Markdown
Collaborator

@yzh119 yzh119 commented Jan 22, 2026

📌 Description

uv.lock should not be part of the package (it was introduced by accident in #2387, this PR removes uv.lock and add it to .gitignore to prevent accidental commits.

Lock files are not recommended for libraries as they can conflict with downstream users' environments.

🔍 Related Issues

#2387

🚀 Pull Request Checklist

Thank you for contributing to FlashInfer! Before we review your pull request, please make sure the following items are complete.

✅ Pre-commit Checks

  • I have installed pre-commit by running pip install pre-commit (or used your preferred method).
  • I have installed the hooks with pre-commit install.
  • I have run the hooks manually with pre-commit run --all-files and fixed any reported issues.

If you are unsure about how to set up pre-commit, see the pre-commit documentation.

🧪 Tests

  • Tests have been added or updated as needed.
  • All tests are passing (unittest, etc.).

Reviewer Notes

This PR itself should not involve any changes related to kernels and we can bypass kernel CI checks.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Jan 22, 2026

Warning

Rate limit exceeded

@yzh119 has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 2 minutes and 33 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @yzh119, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses an issue where a uv.lock file was inadvertently committed to the repository. The core purpose of this change is to remove this lock file and establish a mechanism to prevent its reintroduction, ensuring that the library maintains compatibility and avoids potential dependency conflicts for its consumers.

Highlights

  • Removal of uv.lock: The uv.lock file, which was accidentally introduced in a previous pull request (A Blackwell-optimized version of selective_state_update (mamba) #2387), has been removed from the repository.
  • Preventing future uv.lock commits: The uv.lock file has been added to the .gitignore file to prevent it from being accidentally committed again in the future.
  • Reason for removal: Lock files are generally not recommended for libraries as they can lead to conflicts with the dependency environments of downstream users.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly addresses the issue of a committed lock file in a library. By removing uv.lock and adding it to .gitignore, you are following the best practice for Python libraries, which helps prevent dependency conflicts for downstream users. The change to .gitignore is well-placed and includes a helpful comment explaining the reasoning. This is a solid hotfix that improves the project's maintainability.

@yzh119 yzh119 merged commit e4dee98 into flashinfer-ai:main Jan 22, 2026
17 of 21 checks passed
@claude claude bot mentioned this pull request Jan 23, 2026
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants