Skip to content

ci: add docker cleanup before running tests#2386

Merged
yongwww merged 1 commit intoflashinfer-ai:mainfrom
yongwww:pub_ci_fix
Jan 21, 2026
Merged

ci: add docker cleanup before running tests#2386
yongwww merged 1 commit intoflashinfer-ai:mainfrom
yongwww:pub_ci_fix

Conversation

@yongwww
Copy link
Member

@yongwww yongwww commented Jan 20, 2026

📌 Description

Added a Docker cleanup step before tests run. This helps prevent leftover Docker containers from previous jobs when runners are reused

🔍 Related Issues

🚀 Pull Request Checklist

Thank you for contributing to FlashInfer! Before we review your pull request, please make sure the following items are complete.

✅ Pre-commit Checks

  • I have installed pre-commit by running pip install pre-commit (or used your preferred method).
  • I have installed the hooks with pre-commit install.
  • I have run the hooks manually with pre-commit run --all-files and fixed any reported issues.

If you are unsure about how to set up pre-commit, see the pre-commit documentation.

🧪 Tests

  • Tests have been added or updated as needed.
  • All tests are passing (unittest, etc.).

Reviewer Notes

Summary by CodeRabbit

  • Chores
    • Improved CI/CD infrastructure by optimizing build pipeline timeouts and enhancing system cleanup procedures to ensure reliable test execution.
    • Enhanced development tooling with improved memory information formatting for better readability during system diagnostics.

✏️ Tip: You can customize this high-level summary in your review settings.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @yongwww, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request, according to its title and description, is intended to add a Docker cleanup step to the CI pipeline to ensure a clean environment for test runs by removing orphaned containers. However, the actual patch provided only contains a minor modification to a system information script, changing the free command to free -h for more readable memory output. The core Docker cleanup functionality described in the PR's intent is not present in the current patch.

Highlights

  • Stated PR Intent: The pull request aims to introduce a Docker cleanup step before running tests to prevent leftover containers from previous jobs, as described in the PR title and description.
  • Actual Patch Content: The provided patch, however, only modifies the scripts/task_show_node_info.sh file to change the free command to free -h, which displays memory information in a human-readable format.
  • Discrepancy Noted: There is a significant discrepancy between the stated purpose of the pull request (Docker cleanup) and the actual changes present in the provided patch (a minor update to a system information script). It appears the intended Docker cleanup logic is not included in this patch.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Ignored Files
  • Ignored by pattern: .github/workflows/** (1)
    • .github/workflows/pr-test.yml
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 20, 2026

Note

Other AI code review bot(s) detected

CodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review.

📝 Walkthrough

Walkthrough

CI workflow timeout increased from 300 to 360 minutes across multiple GPU test jobs. Docker cleanup steps added to job cleanup blocks to stop, remove, and prune containers. Memory display output formatting improved with human-readable flags in node info script.

Changes

Cohort / File(s) Summary
GitHub Actions Workflow
.github/workflows/pr-test.yml
Increased job timeout from 300 to 360 minutes (aot-build-import, gpu-tests-a10g, gpu-tests-t4). Added explicit Docker cleanup: stop containers, remove containers, and prune system. Removed comment "# Verify GPU is free". Reordered cleanup commands.
Node Information Script
scripts/task_show_node_info.sh
Changed memory display flag from free to free -h for human-readable output formatting.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

Suggested labels

docker

Suggested reviewers

  • yzh119
  • nvmbreughe

Poem

🐰 Hop, hop—the cleanup squad arrives!
Docker containers, pruned to thrive,
Timeouts stretch from five to six,
Human-readable RAM fix,
CI pipelines purr with grace! 🧹✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately summarizes the main change: adding Docker cleanup in CI before tests run, which directly matches the primary modification in the changeset.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description check ✅ Passed The PR description includes the required sections from the template with a clear description of changes and pre-commit/test checklists, though some checklist items are left unchecked.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request title and description indicate a change related to "docker cleanup before running tests". However, the only code modification in this PR is changing the free command to free -h in scripts/task_show_node_info.sh to display memory information in a human-readable format. While free -h is a good improvement for readability, it does not align with the stated purpose of the pull request. Please clarify if the Docker cleanup logic is missing or if the PR description needs to be updated to accurately reflect the changes.

df --human-readable
lscpu
free
free -h
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The pull request description states that this change adds a Docker cleanup step before tests run. However, the only modification in this file is to display the free command output in a human-readable format (free -h). This change improves the readability of the runner info, but it does not implement any Docker cleanup. Please clarify if the Docker cleanup logic is missing or if the PR description needs to be updated to accurately reflect the changes.

@yongwww yongwww merged commit e9293a7 into flashinfer-ai:main Jan 21, 2026
24 of 40 checks passed
This was referenced Feb 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants