ci: add docker cleanup before running tests#2386
Conversation
Summary of ChangesHello @yongwww, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request, according to its title and description, is intended to add a Docker cleanup step to the CI pipeline to ensure a clean environment for test runs by removing orphaned containers. However, the actual patch provided only contains a minor modification to a system information script, changing the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
|
Note Other AI code review bot(s) detectedCodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review. 📝 WalkthroughWalkthroughCI workflow timeout increased from 300 to 360 minutes across multiple GPU test jobs. Docker cleanup steps added to job cleanup blocks to stop, remove, and prune containers. Memory display output formatting improved with human-readable flags in node info script. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Code Review
The pull request title and description indicate a change related to "docker cleanup before running tests". However, the only code modification in this PR is changing the free command to free -h in scripts/task_show_node_info.sh to display memory information in a human-readable format. While free -h is a good improvement for readability, it does not align with the stated purpose of the pull request. Please clarify if the Docker cleanup logic is missing or if the PR description needs to be updated to accurately reflect the changes.
| df --human-readable | ||
| lscpu | ||
| free | ||
| free -h |
There was a problem hiding this comment.
The pull request description states that this change adds a Docker cleanup step before tests run. However, the only modification in this file is to display the free command output in a human-readable format (free -h). This change improves the readability of the runner info, but it does not implement any Docker cleanup. Please clarify if the Docker cleanup logic is missing or if the PR description needs to be updated to accurately reflect the changes.
📌 Description
Added a Docker cleanup step before tests run. This helps prevent leftover Docker containers from previous jobs when runners are reused
🔍 Related Issues
🚀 Pull Request Checklist
Thank you for contributing to FlashInfer! Before we review your pull request, please make sure the following items are complete.
✅ Pre-commit Checks
pre-commitby runningpip install pre-commit(or used your preferred method).pre-commit install.pre-commit run --all-filesand fixed any reported issues.🧪 Tests
unittest, etc.).Reviewer Notes
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.