Skip to content

Update Docker CI tags to 20251217-f059241 #2231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yzh119 merged 1 commit into from
Dec 17, 2025
Merged

Update Docker CI tags to 20251217-f059241 #2231

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions ci/docker-tags.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
flashinfer/flashinfer-ci-cu126: 20251206-185d63a
flashinfer/flashinfer-ci-cu128: 20251206-185d63a
flashinfer/flashinfer-ci-cu129: 20251206-185d63a
flashinfer/flashinfer-ci-cu130: 20251206-185d63a
flashinfer/flashinfer-ci-cu126: 20251217-f059241
flashinfer/flashinfer-ci-cu128: 20251217-f059241
flashinfer/flashinfer-ci-cu129: 20251217-f059241
flashinfer/flashinfer-ci-cu130: 20251217-f059241
Comment on lines +1 to +4
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Dec 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

To improve maintainability and adhere to the DRY (Don't Repeat Yourself) principle, consider using YAML anchors and aliases. This approach defines the tag once and reuses it for the other images. This makes future updates simpler and less prone to copy-paste errors. Since this file is auto-generated, this change would ideally be implemented in the script that creates this file.

flashinfer/flashinfer-ci-cu126: &ci_tag 20251217-f059241
flashinfer/flashinfer-ci-cu128: *ci_tag
flashinfer/flashinfer-ci-cu129: *ci_tag
flashinfer/flashinfer-ci-cu130: *ci_tag
References
  1. The DRY (Don't Repeat Yourself) principle is a fundamental software development principle aimed at reducing repetition of information. In this case, the Docker image tag is repeated four times. Consolidating it would improve maintainability.