Rename noauxtc to fused_topk_deepseek

[nv-yunzheq]

📌 Description

🔍 Related Issues

🚀 Pull Request Checklist

Thank you for contributing to FlashInfer! Before we review your pull request, please make sure the following items are complete.

✅ Pre-commit Checks

• I have installed pre-commit by running pip install pre-commit (or used your preferred method).
• I have installed the hooks with pre-commit install.
• I have run the hooks manually with pre-commit run --all-files and fixed any reported issues.

If you are unsure about how to set up pre-commit, see the pre-commit documentation.

🧪 Tests

• Tests have been added or updated as needed.
• All tests are passing (unittest, etc.).

Reviewer Notes

Summary by CodeRabbit

• Refactor
  • Updated DeepSeek routing kernel naming within the public API for improved consistency
• Tests
  • Updated test suite to reflect the updated kernel naming convention

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

Walkthrough

A coordinated API rename refactoring that replaces the symbol NoAuxTc with fused_topk_deepseek across the flashinfer module hierarchy, updating function definitions, public exports, and corresponding test references.

Changes

Cohort / File(s)	Summary
Public API Exports flashinfer/dsv3_ops/__init__.py, flashinfer/fused_moe/__init__.py	Updated __all__ lists and import statements to replace NoAuxTc with fused_topk_deepseek; consistent re-export across module hierarchy.
Core Implementation flashinfer/fused_moe/fused_routing_dsv3.py	Renamed public function definition from NoAuxTc to fused_topk_deepseek; signature and decorator preserved.
Test Updates tests/model_optimizations/test_dsv3_fused_routing.py	Updated import statements and function call sites to reference fused_topk_deepseek instead of NoAuxTc.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

• Verify all references to NoAuxTc have been renamed across the entire codebase (search for any stragglers)
• Confirm the import chains remain unbroken through the module hierarchy
• Ensure test coverage validates the renamed function correctly

Poem

🐰 From NoAuxTc to fused_topk_deepseek we hop,
A name more clear, semantic and pop!
Through modules we skip, imports aligned,
Tests all refined, no stone left behind.
What once was obscure now dances so bright! ✨

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Description check	⚠️ Warning	The description is incomplete, containing only the repository template with unchecked checkboxes and no actual content filling the required sections like what the PR does, why it's needed, or related issues.	Fill in the 📌 Description section explaining the rename rationale, add any 🔍 Related Issues links, and verify the checklist items have been completed before merging.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly and specifically describes the main change: renaming NoAuxTc to fused_topk_deepseek, which aligns with the changeset across all modified files.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between b972005 and 50a775a.

📒 Files selected for processing (4)

• flashinfer/dsv3_ops/__init__.py (1 hunks)
• flashinfer/fused_moe/__init__.py (2 hunks)
• flashinfer/fused_moe/fused_routing_dsv3.py (1 hunks)
• tests/model_optimizations/test_dsv3_fused_routing.py (4 hunks)

🧰 Additional context used

🧬 Code graph analysis (2)

tests/model_optimizations/test_dsv3_fused_routing.py (1)

flashinfer/fused_moe/fused_routing_dsv3.py (1)

• fused_topk_deepseek (119-194)

flashinfer/fused_moe/__init__.py (1)

flashinfer/fused_moe/fused_routing_dsv3.py (1)

• fused_topk_deepseek (119-194)

🔇 Additional comments (4)

tests/model_optimizations/test_dsv3_fused_routing.py (2)

2-4: LGTM! Import and documentation updated correctly.

The test file has been properly updated to import and reference fused_topk_deepseek instead of NoAuxTc. The docstring accurately reflects the new function name.

Also applies to: 121-121

---

432-432: LGTM! Function call updated correctly.

The test correctly invokes fused_topk_deepseek with the same parameters and validation logic. The rename is applied consistently.

Also applies to: 476-486

flashinfer/dsv3_ops/__init__.py (1)

2-2: LGTM! Public API export updated correctly.

The module now correctly imports and exports fused_topk_deepseek instead of NoAuxTc, maintaining proper module boundaries.

Also applies to: 6-6

flashinfer/fused_moe/__init__.py (1)

38-38: Verify that the import/export pattern is complete and no dangling references to NoAuxTc remain.

The module re-exports fused_topk_deepseek from fused_routing_dsv3 at lines 38 and 59. To ensure the rename is fully complete, search the codebase for any remaining references to NoAuxTc (excluding internal wrapper implementations) and check documentation files for any outdated API references.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[gemini-code-assist]

Summary of Changes

Hello @nv-yunzheq, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request performs a straightforward refactoring by renaming the NoAuxTc kernel to fused_topk_deepseek. This change improves code clarity and consistency by aligning the function's name with its specific purpose, which is likely related to fused top-k operations for DeepSeek models. The modification is purely cosmetic and does not alter the functionality of the kernel, ensuring no behavioral changes.

Highlights

• Function Renaming: The NoAuxTc function/kernel has been consistently renamed to fused_topk_deepseek across the entire codebase, including its definition and all references.
• Import and Export Updates: All relevant import statements and __all__ lists in flashinfer/dsv3_ops/__init__.py and flashinfer/fused_moe/__init__.py have been updated to reflect the new fused_topk_deepseek name.
• Test Suite Alignment: The test file tests/model_optimizations/test_dsv3_fused_routing.py has been updated to use the new fused_topk_deepseek name in its imports, comments, docstrings, and function calls, ensuring test continuity.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request renames the NoAuxTc function to fused_topk_deepseek across the codebase. The change includes updating the function definition in flashinfer/fused_moe/fused_routing_dsv3.py, modifying import and export statements in flashinfer/fused_moe/__init__.py and flashinfer/dsv3_ops/__init__.py, and updating all references, comments, and function calls in the associated test file tests/model_optimizations/test_dsv3_fused_routing.py. No review comments were provided.

[pavanimajety]

Thanks for the quick fix