ci: Create Github Action to Automate CODEOWNER update#1869
ci: Create Github Action to Automate CODEOWNER update#1869yzh119 wants to merge 12 commits intoflashinfer-ai:mainfrom
Conversation
Summary of ChangesHello @yzh119, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request aims to improve the maintenance of code ownership within the repository by establishing an automated weekly process for updating the CODEOWNERS file via a GitHub Action. The core change involves enhancing the existing Highlights
Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a max_depth parameter to the codeowner_analyzer.py script to control directory depth during module analysis. The implementation is sound, adding the parameter to the class, command-line parser, and using it in the module discovery logic. I have one suggestion to add input validation for max_depth to handle non-positive values gracefully. It would also be highly beneficial to add unit tests for this script to verify the new functionality and prevent future regressions. Please note that while the PR title mentions creating a GitHub Action, this change appears to be a preparatory step as no workflow files are included.
| self.repo_path = Path(repo_path).resolve() | ||
| self.min_commits = min_commits | ||
| self.days_back = days_back | ||
| self.max_depth = max_depth |
There was a problem hiding this comment.
It's good practice to validate input parameters. The max_depth should be a positive integer. A value of 0 or less would result in no modules being detected, which might be unexpected. Consider adding a check to ensure max_depth is positive.
if max_depth <= 0:
raise ValueError("max_depth must be a positive integer.")
self.max_depth = max_depthThis reverts commit 3934511.
Testing if the token has permission to create PRs from pull_request trigger. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
|
Closed and move to #1870 |
<!-- .github/pull_request_template.md --> ## 📌 Description Duplicate of #1869 but created from flashinfer/workflow-update-codeowner to make sure we have permission. This PR introduces a GitHub Action that automatically creates pull requests to update the CODEOWNERS file. * Scheduled: Runs weekly by default * Manual: Can be triggered on-demand through the Actions tab This PR also adds functionality to the `codeowner_analyzer.py`: * `--depth`: Maximum directory depth for module detection (default: 3) * `--top-n`: Number of top owners to include in CODEOWNERS file (default: 3) Example can be found at https://github.com/flashinfer-ai/flashinfer/pull/1871/files ## 🔍 Related Issues <!-- Link any related issues here --> ## 🚀 Pull Request Checklist Thank you for contributing to FlashInfer! Before we review your pull request, please make sure the following items are complete. ### ✅ Pre-commit Checks - [x] I have installed `pre-commit` by running `pip install pre-commit` (or used your preferred method). - [x] I have installed the hooks with `pre-commit install`. - [x] I have run the hooks manually with `pre-commit run --all-files` and fixed any reported issues. > If you are unsure about how to set up `pre-commit`, see [the pre-commit documentation](https://pre-commit.com/). ## 🧪 Tests - [x] Tests have been added or updated as needed. - [x] All tests are passing (`unittest`, etc.). ## Reviewer Notes cc @sricketts @yongwww @nvmbreughe @bkryu @dierksen <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit ## Release Notes * **New Features** * Introduced automated CODEOWNERS file updates via GitHub Actions workflow, running weekly on Mondays with manual trigger support and automatic pull request creation for detected changes. * **Chores** * Enhanced code owner analysis tool with improved configuration options for module depth and top owner selection limits. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Co-authored-by: Claude <noreply@anthropic.com>
1 participant
📌 Description
Create a github action that will send PR to update CODEOWNER (weekly).
🔍 Related Issues
🚀 Pull Request Checklist
Thank you for contributing to FlashInfer! Before we review your pull request, please make sure the following items are complete.
✅ Pre-commit Checks
pre-commitby runningpip install pre-commit(or used your preferred method).pre-commit install.pre-commit run --all-filesand fixed any reported issues.🧪 Tests
unittest, etc.).Reviewer Notes