jit: add get_object_paths to JitSpec#1836
Conversation
This commit reverts changes in flashinfer-ai#1802, and adds a new method `get_object_paths` to JITSpec, which returns the paths of all compiled object files. For applications that want to get the object files rather than the loaded shared library (such as MLC model compilation), this method could be leveraged.
Summary of ChangesHello @MasterJH5574, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the JIT compilation capabilities by adding a new method, Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces a new get_object_paths method in JitSpec and reverts some previous changes. The new method is well-implemented, although I've suggested a minor refinement for conciseness. A more significant issue is in csrc/batch_decode.cu, where the removal of the <flashinfer/attention/decode.cuh> header will likely break compilation because it removes a required template function definition. This needs to be addressed.
📌 Description
This commit reverts changes in #1802, and adds a new method
get_object_pathsto JITSpec, which returns the paths of all compiled object files. For applications that want to get the object files rather than the loaded shared library (such as MLC model compilation), this method could be leveraged.🔍 Related Issues
N/A
🚀 Pull Request Checklist
Thank you for contributing to FlashInfer! Before we review your pull request, please make sure the following items are complete.
✅ Pre-commit Checks
pre-commitby runningpip install pre-commit(or used your preferred method).pre-commit install.pre-commit run --all-filesand fixed any reported issues.🧪 Tests
unittest, etc.).Reviewer Notes