Skip to content

jit: add get_object_paths to JitSpec#1836

Merged
yzh119 merged 1 commit intoflashinfer-ai:mainfrom
MasterJH5574:10-01-jit-obj
Oct 2, 2025
Merged

jit: add get_object_paths to JitSpec#1836
yzh119 merged 1 commit intoflashinfer-ai:mainfrom
MasterJH5574:10-01-jit-obj

Conversation

@MasterJH5574
Copy link
Copy Markdown
Collaborator

@MasterJH5574 MasterJH5574 commented Oct 1, 2025

📌 Description

This commit reverts changes in #1802, and adds a new method get_object_paths to JITSpec, which returns the paths of all compiled object files. For applications that want to get the object files rather than the loaded shared library (such as MLC model compilation), this method could be leveraged.

🔍 Related Issues

N/A

🚀 Pull Request Checklist

Thank you for contributing to FlashInfer! Before we review your pull request, please make sure the following items are complete.

✅ Pre-commit Checks

  • I have installed pre-commit by running pip install pre-commit (or used your preferred method).
  • I have installed the hooks with pre-commit install.
  • I have run the hooks manually with pre-commit run --all-files and fixed any reported issues.

If you are unsure about how to set up pre-commit, see the pre-commit documentation.

🧪 Tests

  • Tests have been added or updated as needed.
  • All tests are passing (unittest, etc.).

Reviewer Notes

This commit reverts changes in flashinfer-ai#1802, and adds a new method
`get_object_paths` to JITSpec, which returns the paths of all
compiled object files. For applications that want to get the object
files rather than the loaded shared library (such as MLC model
compilation), this method could be leveraged.
@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @MasterJH5574, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the JIT compilation capabilities by adding a new method, get_object_paths, to the JITSpec class. This method allows users to retrieve the file paths of compiled object files, which is crucial for advanced compilation scenarios like MLC model compilation where intermediate object files are processed further. The PR also includes minor code hygiene improvements such as removing an unnecessary header and reordering imports.

Highlights

  • New JITSpec Method: Introduced get_object_paths to the JITSpec class, which provides a list of paths to all compiled object files generated during JIT compilation.
  • Enhanced Compilation Flexibility: This new method supports applications that require access to individual object files rather than the final linked shared library, such as MLC model compilation workflows.
  • Code Cleanup: Removed an unused include statement (flashinfer/attention/decode.cuh) from csrc/batch_decode.cu.
  • Import Reordering: Reordered import statements in flashinfer/jit/core.py for improved code organization.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new get_object_paths method in JitSpec and reverts some previous changes. The new method is well-implemented, although I've suggested a minor refinement for conciseness. A more significant issue is in csrc/batch_decode.cu, where the removal of the <flashinfer/attention/decode.cuh> header will likely break compilation because it removes a required template function definition. This needs to be addressed.

@yzh119 yzh119 merged commit 85445d5 into flashinfer-ai:main Oct 2, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants