Perf: support scale_a/scale_b instead of combined scale in cutlass bmm_fp8#1491
Conversation
There was a problem hiding this comment.
Summary of Changes
Hello @ttyio, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request introduces a performance optimization for FP8 Batch Matrix Multiplication (BMM) within the Cutlass library. Previously, the scale_a and scale_b parameters had to be combined in Python using an extra ATen kernel, incurring a 1-microsecond overhead. This change modifies the Cutlass implementation to directly support separate scale_a and scale_b values within the epilogue, thereby eliminating the need for the external kernel and improving overall performance of FP8 GEMM operations.
Highlights
- Direct Scale Handling: The Cutlass FP8 GEMM implementation now directly accepts separate
scale_aandscale_btensors, eliminating the need for pre-combining them in Python. - Performance Improvement: This change avoids an extra ATen kernel call that previously added approximately 1 microsecond of overhead, leading to performance gains for FP8 BMM operations.
- Epilogue Fusion Update: The Cutlass epilogue fusion logic has been updated to incorporate the separate
scale_aandscale_bvalues, performing the scaling operation directly within the GPU kernel. - API and Internal Changes: The
runGemmandfp8_bmm_implfunctions in C++ andcutlass_fp8_gemmin Python have been refactored to accommodate the newscale_aandscale_bparameters.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request introduces a performance optimization by avoiding the host-side multiplication of scale_a and scale_b for FP8 GEMM operations. Instead, the scales are passed separately to the CUTLASS kernel and handled within the epilogue, which eliminates an unnecessary kernel launch. The changes are consistently applied across both the Python and C++ codebases and appear to be functionally correct. My feedback primarily focuses on improving code readability and maintainability by reformatting some long lines in the C++ template files.
|
There are some conflicts on |
828e3eb to
001005b
Compare
rebased, thank you! |
Previous cutlass implementation require combine of scale_a/scale_b in the python, so extra aten kernel is used which may cost 1us. Now we support separate alpha_a and alpha_b in epilog, to avoid this extra aten kernel. Signed-off-by: Vincent Huang <vincenth@nvidia.com>
001005b to
06747c3
Compare
Previous cutlass implementation require combine of scale_a/scale_b in the python, so extra aten kernel is used which may cost 1us. Now we support separate alpha_a and alpha_b in epilog, to avoid this extra aten kernel.
📌 Description
🔍 Related Issues
🚀 Pull Request Checklist
Thank you for contributing to FlashInfer! Before we review your pull request, please make sure the following items are complete.
✅ Pre-commit Checks
pre-commitby runningpip install pre-commit(or used your preferred method).pre-commit install.pre-commit run --all-filesand fixed any reported issues.🧪 Tests
unittest, etc.).Reviewer Notes