Skip to content

Conversation

@codingjoe
Copy link
Contributor

@codingjoe codingjoe commented Mar 26, 2018

Python str.format() is marked as #, python-brace-format in *.po
(portable object) files.

Python str.format() is marked as `#, python-brace-format` in *.po
(portable object) files.
@flashcode flashcode merged commit 574e00f into flashcode:master Mar 26, 2018
@flashcode
Copy link
Owner

Thanks, I'll shorten the function names in tests to make pylint happy.

@flashcode flashcode self-assigned this Mar 26, 2018
@flashcode flashcode added this to the 3.0 milestone Mar 26, 2018
@codingjoe codingjoe deleted the python-braces branch March 26, 2018 20:28
@codingjoe
Copy link
Contributor Author

Cool, thx! Let me know when you release 3.0! Looking forward to it. That way we can finally put our other spell checking script to rest.
BTW, any plans regarding the pyenchant problem? With it no longer being maintained and all?

@flashcode flashcode added the bug Unexpected problem or unintended behavior label Mar 27, 2018
@flashcode
Copy link
Owner

For release 3.0, I'll wait a bit, I prefer something tested and stable.

What's the problem with pyenchant? The 2.0.0 version was released on Dec 2017, but yes, weird the site gives a 404 error.

@codingjoe
Copy link
Contributor Author

The maintainer discontinued the project :/
https://rfk.id.au/blog/entry/archiving-open-source-projects/

What tests are missing? I'm happy to write a couple if you point me towards the right direction.

@flashcode
Copy link
Owner

By "tests" I don't mean automatic tests (like unit tests), but manual testing of the devel version. More generally I don't like releasing a software immediately after fixing bugs or adding new features, I prefer waiting a bit to check if everything works well, then I make the release.

For pyenchant we could maybe wait to see if someone will continue the project before changing anything in msgcheck.

@codingjoe
Copy link
Contributor Author

Ok, @flashcode I will upgrade our test suites to use the current HEAD.

Regarding pyenchant, it isn't hard dependency right? I saw some try, except block around the import. I would probably drop it from the requirements, so it isn't installed by default.

I have a college that already has problems with pyenchant, since enchant 2 is not supported.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Unexpected problem or unintended behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants