Closed
Conversation
bharath-123
commented
Jul 21, 2025
Cargo.toml
Outdated
| reth-payload-util = { git = "https://github.com/paradigmxyz/reth", tag = "v1.4.8" } | ||
| reth-rpc-layer = { git = "https://github.com/paradigmxyz/reth", tag = "v1.4.8" } | ||
| reth-testing-utils = { git = "https://github.com/paradigmxyz/reth", tag = "v1.4.8" } | ||
| reth-chainspec = { git = "https://github.com/bharath-123/reth", branch = "bharath/fusaka-revm-fix" } |
Contributor
Author
There was a problem hiding this comment.
The current reth fusaka-devnet-2 branch breaks with rbuilder because of breaking changes in revm with eip-7097. This should be resolved by fusaka-devnet-3. We are temporarily using a fork of reth for now.
bharath-123
commented
Jul 21, 2025
Comment on lines
+733
to
+735
| blobs_sidecar: Arc::new(BlobTransactionSidecarVariant::Eip4844( | ||
| BlobTransactionSidecar::default(), | ||
| )), |
Contributor
Author
There was a problem hiding this comment.
We ideally need to know which fork we are currently at, in order to create an EIP-4844 type sidecar or EIP-7954 sidecar. We unfortunately don't have this info here.
bharath-123
commented
Jul 21, 2025
| let blob_sidecar = pool | ||
| .get_blob(*tx.inner().hash())? | ||
| .and_then(|b| b.as_eip4844().cloned()); | ||
| let mut blobs = pool.get_all_blobs(vec![*tx.inner().hash()])?; |
Contributor
Author
There was a problem hiding this comment.
pool.get_blob wasn't able to retrive the blob in my testing. using pool.get_all_blobs worked in this case.
4 tasks
Collaborator
|
Covered by #698 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates rbuilder to support Fusaka. These changes have been tested locally using Kurtosis
Things to consider in rbuilder:
Breaking changes:
U256representation alloy-rs/nybbles#17 updates the internal representation ofNibblefrom aSmallVec<[u8; 64]>to aU256. This breaks code in the merkle eth sparse tree as the code indexes a lot into theSmallVecrepresentationBlobTransactionSidecarVariantenum which contains PeerDas type blob sidecars too. The only different b/w EIP-7954 sidecars from EIP-4844 sidecars is EIP-7954 sidecars usecell_proofsinstead ofproofs. rbuilder just usesBlobTransactionSidecarwhich breaks with the fulu hard fork.BlockNumberandTimestampto useU256instead ofu64. There are inconsistencies in code where u64 is used for block number which fails to build as a result.CodeSizefield to theAccountInfo. It was previously anOptionbut the mentioned commit makes it a mandatory field.Databasetrait in the alloy/evm repo now implementsstd::fmt::Debugimplemented by alloy-rs/evm@3d6a01b. This broke code since a dependency was using the updatedDatabasetrait from alloy/evm. Using theDatabasetrait from alloy/evm seems to have fixed this.stepmethod has been removed from theaccess_list_inspector. We need to update therevm-inspectorscrate.bytecode_by_hashis now defined in traitBytecodeReaderrather than in theStateProviderNotes
BlobsBundleV2to the relay. https://github.com/alloy-rs/alloy/blob/fusaka/devnet2/crates/rpc-types-engine/src/payload.rs#L906SignedBidSubmissionV5to the relay overall: https://github.com/alloy-rs/alloy/blob/main/crates/rpc-types-beacon/src/relay.rs#L183✅ I have completed the following steps:
make lintmake test