Stage 2: Header Forwarding for protect-rpc Integration #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove buildBackendURL() function entirely (~25 lines removed) - Replace with clean header forwarding approach (~10 lines added) - Forward X-Original-Path and X-Original-Query headers for all methods - Keep backend URL unchanged (no path/query modification) - Remove obsolete TestBackendURLBuilding test This is the clean approach for proxyd->protect-rpc communication: - proxyd handles HTTP routing and forwards context via headers - protect-rpc reads ONLY from headers, never from request URL - No config changes needed (headers are automatically forwarded) 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
- Test X-Original-Path and X-Original-Query header forwarding - Verify headers are set correctly from context values - Cover edge cases: root path, empty query, no context values - Ensures proxyd->protect-rpc header conversion works correctly 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
odysseus0
force-pushed
the
stage2-protect-rpc
branch
from
0cf80d4 to
b7041b7
Compare
odysseus0
force-pushed
the
stage1-legacy-compat
branch
2 times, most recently
from
e53225d to
11b68d6
Compare
Logs when X-Original-Path/Query headers are being forwarded to backends. Enables end-to-end tracing of Stage 2 header-based URL forwarding. Includes path, query, and req_id for CloudWatch correlation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stage 2: Header Forwarding for protect-rpc Integration
Status:⚠️ Depends on #4 (Stage 1) - Review in parallel, merge after Stage 1
Deployment: 🚫 Blocked by Redis architecture decision in flashbots/devops#1643
Overview
Stage 2 introduces header forwarding for clean integration with the new
protect-rpcservice on Sepolia testnet.Key Change: Removes
buildBackendURL()URL forwarding in favor of HTTP headers (X-Original-Path,X-Original-Query).Changes
X-Original-PathandX-Original-Queryheadersprotect-rpcservice (not legacy rpc-endpoint)Related PRs
Architecture
Testing
845745288226.dkr.ecr.us-east-2.amazonaws.com/proxyd:0cf80d4Deployment Plan
Target: Sepolia testnet only (after Redis decision)