Modity flashblocks ws bind/port flags #71
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ferranbt
commented
May 27, 2025
crates/op-rbuilder/src/args/op.rs
Outdated
|
|
||
| /// flashblock block time in milliseconds | ||
| #[arg( | ||
| long = "rollup.flashblock-block-time", |
Contributor
Author
There was a problem hiding this comment.
We can have a followup issue to deprecate this flags.
ferranbt
commented
May 27, 2025
| network_port: Option<u16>, | ||
| builder_private_key: Option<String>, | ||
| flashblocks_ws_url: Option<String>, | ||
| flashblocks_port: Option<u16>, |
Contributor
Author
There was a problem hiding this comment.
Using port here since we do not really have any utility to change the bind address during tests.
ferranbt
commented
May 27, 2025
karim-agha
approved these changes
May 27, 2025
|
|
||
| if let Some(flashblocks_ws_url) = &self.flashblocks_ws_url { | ||
| if let Some(flashblocks_port) = &self.flashblocks_port { | ||
| cmd.arg("--rollup.enable-flashblocks").arg("true"); |
Contributor
There was a problem hiding this comment.
Wondering if we should also rename rollup.enable-flashblocks to flashblocks.enabled to be more consistent.
Contributor
Author
There was a problem hiding this comment.
I was worried since Base is already using this code. But I think it should be fine. We do not provide yet any API guarantees. I am going to change the one about the flashblocks block time too.
SozinM
approved these changes
May 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
Closes #70