Conversation
akundaz
requested review from
0x416e746f6e,
SozinM,
avalonche and
karim-agha
as code owners
julio4
reviewed
Feb 24, 2026
Member
julio4
left a comment
julio4
left a comment
There was a problem hiding this comment.
This looks good but the standard builder don't make much sense anymore, should we deprecate it?
akundaz
force-pushed
the
ash-uwrswrrnvvun
branch
from
518329c to
a5b43a6
Compare
dvush
approved these changes
Feb 25, 2026
akundaz
force-pushed
the
ash-uwrswrrnvvun
branch
from
a5b43a6 to
7ae016c
Compare
This was referenced Feb 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the generic soup with the tradeoff of adding two more args to the
add_builder_txsfunction. Next step would be to clean up the builder txs code