Update builder-playground usage for local devnet runs and testing#395
Update builder-playground usage for local devnet runs and testing#395
Conversation
canercidam
requested review from
0x416e746f6e,
SozinM,
avalonche and
karim-agha
as code owners
akundaz
left a comment
akundaz
left a comment
There was a problem hiding this comment.
LGTM. Is this meant to be for CI testing or for local usage? I always set the --block-time 1 arg when running builder playground and some other flashblocks related args on the builder
| long = "builder.playground", | ||
| num_args = 0..=1, | ||
| default_missing_value = "$HOME/.playground/devnet/", | ||
| default_missing_value = "$HOME/.local/state/builder-playground/devnet", |
There was a problem hiding this comment.
should we take into account $XDG_STATE_HOME? Maybe if not defined fallback to $HOME/.local/state in expand_path?
There was a problem hiding this comment.
Yeah, I thought the same but I was a little afraid of everyone having to do that. It's a small piece of complexity from the playground itself so maybe playground could tell it from builder-playground dir and we could rely on that here? (which should also allow a user to do cd $(builder-playground dir) easily.)
|
We could potentially remove playground mod. |
|
@akundaz The same setup in the recipe file supports both CI and local runs (and using for both in this PR). You could provide those flags from |
…tokio-tar * upstream/main: chore: rename bundle fields for consistency (no api change) (flashbots#402) Hotfix: pin nightly version to resolve str::as_str() regression (flashbots#401) update builder-playground usage for local devnet runs and testing (flashbots#395)
3 participants
📝 Summary
playground.yamlfor easy local devnet runs and testing in CI--builder.playgroundflag is used💡 Motivation and Context
builder-playground now supports unifying local and test run configurations under custom recipe files like
playground.yamland allows more simplicity in adding/overriding parameters. This PR brings the latest builder-playground experience for local devnet runs and introduces CI integration.✅ I have completed the following steps:
make lintmake testAdded tests (if applicable)