Skip to content

fix: Resolve bugs introduced from new flashblocks timing logic #393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sieniven wants to merge 6 commits into from
Closed

fix: Resolve bugs introduced from new flashblocks timing logic #393

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
1f69a0a
Fix send offset issue
sieniven Feb 19, 2026
aab6f49
Fix and add more test coverage
sieniven Feb 19, 2026
dfc03c9
Fix first flashblock building not triggered issue
sieniven Feb 19, 2026
a3fdd7e
Better fixes
sieniven Feb 19, 2026
61d92c1
Restore old behaviour
sieniven Feb 19, 2026
3caa5c6
Fix doc
sieniven Feb 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion crates/op-rbuilder/src/builders/flashblocks/payload.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -460,7 +460,12 @@ where
schedule = ?flashblock_scheduler,
"Computed flashblock timing schedule"
);
let target_flashblocks = flashblock_scheduler.target_flashblocks();

// Get target number of flashblocks to build. If no flashblocks are scheduled, return early.
let Some(target_flashblocks) = flashblock_scheduler.target_flashblocks() else {
self.record_flashblocks_metrics(&ctx, &info, 0, &span);
return Ok(());
};

let expected_flashblocks = self.config.flashblocks_per_block();
if target_flashblocks < expected_flashblocks {
Expand Down Expand Up @@ -557,6 +562,11 @@ where
};
let _entered = fb_span.enter();

if ctx.flashblock_index() > ctx.target_flashblock_count() {
self.record_flashblocks_metrics(&ctx, &info, target_flashblocks, &span);
return Ok(());
}

// Build flashblock after receiving signal
let next_flashblocks_ctx = match self.build_next_flashblock(
&ctx,
Expand Down
Loading