fix: attempt to send one flashblock if payload deadline is in the past#386
Merged
fix: attempt to send one flashblock if payload deadline is in the past#386
Conversation
avalonche
approved these changes
Feb 12, 2026
Contributor
|
@akundaz I am curious about the motivations here for this PR - why do we want to build 1 flashblock if FCU is already late? Often times this happens when the chain is catching up to protocol time - dont we want to simply build empty blocks (with optimism system tx) inside it? |
This was referenced Feb 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Summary
When the payload timestamp is in the past, the remaining time calculation now returns 0 instead of falling back to block time. This triggers an immediate flashblock build, giving us a change to at least get one out before the impending
engine_getPayloadcall, which comes ~20-30ms after the FCU when it's this late.💡 Motivation and Context
Observed timeline
With the old behavior, the scheduler would compute remaining_time = 1000ms (full block time) and schedule the first flashblock at ~170ms, which is well after getPayload arrives. This meant zero flashblocks could be emitted for that block and that the planned schedule would be misleading, since we'd miss all five planned flashblocks.
✅ I have completed the following steps:
make lintmake test