Add variable builder deadline #28
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
SozinM
reviewed
May 13, 2025
| #[arg(long = "builder.log-pool-transactions", default_value = "false")] | ||
| pub log_pool_transactions: bool, | ||
| /// How much time extra to wait for the block building job to complete and not get garbage collected | ||
| #[arg(long = "builder.extra-block-deadline-secs", default_value = "20")] |
Member
There was a problem hiding this comment.
question: is it still --builder.extra-block-deadline-secs or --builder.extra-block-deadline-ms?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
This PR introduces an argument to make the configure the extra deadline time to wait for the payload request before dropping the block building routine.