Add remote quote provider arg for flashtestations #276
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SozinM
reviewed
Sep 25, 2025
| env = "FLASHTESTATIONS_DEBUG_TEE_KEY_SEED", | ||
| default_value = "debug" | ||
| )] | ||
| pub debug_tee_key_seed: String, |
There was a problem hiding this comment.
Also mark somehow that it's not for production
There was a problem hiding this comment.
it has a default value and won't be used if debug not enabled so it won't be a required arg. Option will be same logic by having .unwrap_else("debug")
avalonche
force-pushed
the
quote-provider
branch
from
7a7f267 to
c25eb21
Compare
SozinM
reviewed
Sep 25, 2025
SozinM
approved these changes
Sep 25, 2025
avalonche
force-pushed
the
quote-provider
branch
from
c25eb21 to
ea36b9c
Compare
avalonche
force-pushed
the
quote-provider
branch
from
ea36b9c to
a817850
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
💡 Motivation and Context
Allow the external tdx provider to fetch attestations
✅ I have completed the following steps:
make lintmake test