Skip to content

Remove without_updates for flashblocks #198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 11, 2025
Merged

Remove without_updates for flashblocks #198

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions crates/op-rbuilder/src/builders/flashblocks/payload.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,6 @@ use reth_revm::{
db::{states::bundle_state::BundleRetention, BundleState},
State,
};
use reth_transaction_pool::BestTransactions;
use revm::Database;
use rollup_boost::{
ExecutionPayloadBaseV1, ExecutionPayloadFlashblockDeltaV1, FlashblocksPayloadV1,
Expand Down Expand Up @@ -386,11 +385,9 @@ where

let best_txs_start_time = Instant::now();
let best_txs = BestPayloadTransactions::new(
// TODO: once this issue is fixed we could remove without_updates and rely on regular impl
// https://github.com/paradigmxyz/reth/issues/17325
// We are not using without_updates in here, so arriving transaction could target the current block
self.pool
.best_transactions_with_attributes(ctx.best_transaction_attributes())
.without_updates(),
.best_transactions_with_attributes(ctx.best_transaction_attributes()),
);
ctx.metrics
.transaction_pool_fetch_duration
Expand Down
Loading