Skip to content

reject prysm getHeader#351

Merged
metachris merged 5 commits intomainfrom
prysm-get-header
Apr 14, 2023
Merged

reject prysm getHeader#351
metachris merged 5 commits intomainfrom
prysm-get-header

Conversation

@michaelneuder
Copy link
Collaborator

@michaelneuder michaelneuder commented Apr 13, 2023

📝 Summary

During capella the relays see failures in prysm signatures with the error:

could not verify capella payload signature

This PR rejects getHeader requests from prysm clients based on the UserAgent.

✅ I have run these commands

  • make lint
  • make test-race
  • go mod tidy
  • I have seen and agree to CONTRIBUTING.md

@codecov-commenter
Copy link

codecov-commenter commented Apr 13, 2023

Codecov Report

Merging #351 (96ecbda) into main (2d2bdc0) will decrease coverage by 0.03%.
The diff coverage is 0.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main     #351      +/-   ##
==========================================
- Coverage   17.73%   17.71%   -0.03%     
==========================================
  Files          20       20              
  Lines        3698     3703       +5     
==========================================
  Hits          656      656              
- Misses       2959     2964       +5     
  Partials       83       83              
Flag Coverage Δ
unittests 17.71% <0.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
services/api/service.go 13.06% <0.00%> (-0.06%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@sukoneck sukoneck closed this Apr 13, 2023
@metachris metachris reopened this Apr 13, 2023
@ihooni
Copy link

ihooni commented Apr 13, 2023

Prysm is now fixing this issue

OffchainLabs/prysm#12263

@metachris metachris merged commit b7e54c1 into main Apr 14, 2023
@metachris metachris deleted the prysm-get-header branch April 14, 2023 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants