add indexes to IFlashtestationRegistry and IBlockBuilderPolicy events #41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This addresses N-05 of the Q3 2025 OZ audit: Throughout the codebase, several events do not have indexed parameters: The WorkloadAddedToPolicy event of BlockBuilderPolicy.sol. The WorkloadRemovedFromPolicy event of BlockBuilderPolicy.sol. The RegistrySet event of BlockBuilderPolicy.sol. The BlockBuilderProofVerified event of BlockBuilderPolicy.sol. The TEEServiceRegistered event of IFlashtestationRegistry.sol. The TEEServiceInvalidated event of IFlashtestationRegistry.sol. To improve the ability of off-chain services to search and filter for specific events, consider indexing event parameters. Note: we didn't add it to the BlockBuilderProofVerified event, in order to keep that event as efficient as possible
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses N-05 of the Q3 2025 OZ audit:
Throughout the codebase, several events do not have indexed parameters:
The WorkloadAddedToPolicy event of BlockBuilderPolicy.sol.
The WorkloadRemovedFromPolicy event of BlockBuilderPolicy.sol.
The RegistrySet event of BlockBuilderPolicy.sol.
The BlockBuilderProofVerified event of BlockBuilderPolicy.sol.
The TEEServiceRegistered event of IFlashtestationRegistry.sol.
The TEEServiceInvalidated event of IFlashtestationRegistry.sol.
To improve the ability of off-chain services to search and filter for specific events, consider indexing event parameters.
Note: we didn't add it to the BlockBuilderProofVerified event, in order to keep that event as efficient as possible