Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial tag load performance improvement #87

Merged
merged 22 commits into from
May 4, 2021
Merged

Initial tag load performance improvement #87

merged 22 commits into from
May 4, 2021

Commits on Apr 22, 2021

  1. attempted fix for performance issue loading all tags on index

    @luceos @askvortsov1
    luceos authored and askvortsov1 committed Apr 22, 2021
    Configuration menu
    Copy the full SHA
    991bef5 View commit details
    Browse the repository at this point in the history

  2. Show only top primary tags. And load all secondary/helper tags. 

    This code drops the sub tags so that forums with many tags wont load
the state unecessarily for each sub tag.

I've attempted to load only the 3 tags with most discusssions withCount(),
but the issue is that the subquery doesn't allow using a limit in MySQL.

We can further improve this logic, but that requires discussion.

Please note that specific tag pages aren't affected because they have
their own logic!
    @luceos @askvortsov1
    luceos authored and askvortsov1 committed Apr 22, 2021
    Configuration menu
    Copy the full SHA
    9adbf98 View commit details
    Browse the repository at this point in the history

  3. started moving lots of the request into a show tag controller with in… 

    …cludes
    @luceos @askvortsov1
    luceos authored and askvortsov1 committed Apr 22, 2021
    Configuration menu
    Copy the full SHA
    9b1d3e7 View commit details
    Browse the repository at this point in the history

  4. Apply fixes from StyleCI

    @luceos @askvortsov1
    luceos authored and askvortsov1 committed Apr 22, 2021
    Configuration menu
    Copy the full SHA
    f85b151 View commit details
    Browse the repository at this point in the history

  5. Fixed 

    - admin page listing
- ajaxified sidenav
- tags page
- non-js tags page
    @luceos @askvortsov1
    luceos authored and askvortsov1 committed Apr 22, 2021
    Configuration menu
    Copy the full SHA
    cafa923 View commit details
    Browse the repository at this point in the history

  6. Apply fixes from StyleCI

    @luceos @askvortsov1
    luceos authored and askvortsov1 committed Apr 22, 2021
    Configuration menu
    Copy the full SHA
    2a825bd View commit details
    Browse the repository at this point in the history

  7. Revert changes

    @askvortsov1
    askvortsov1 committed Apr 22, 2021
    Configuration menu
    Copy the full SHA
    3d131ef View commit details
    Browse the repository at this point in the history

  8. Cleanup

    @askvortsov1
    askvortsov1 committed Apr 22, 2021
    Configuration menu
    Copy the full SHA
    9157cef View commit details
    Browse the repository at this point in the history

  9. Apply fixes from StyleCI

    @askvortsov1 @StyleCIBot
    askvortsov1 authored and StyleCIBot committed Apr 22, 2021
    Configuration menu
    Copy the full SHA
    4fd9164 View commit details
    Browse the repository at this point in the history

  10. More fixes

    @askvortsov1
    askvortsov1 committed Apr 22, 2021
    Configuration menu
    Copy the full SHA
    485a930 View commit details
    Browse the repository at this point in the history

  11. Revert whitespace change

    @askvortsov1
    askvortsov1 committed Apr 22, 2021
    Configuration menu
    Copy the full SHA
    520352f View commit details
    Browse the repository at this point in the history

  12. Load in tags for composer and TagDiscussionModal

    @askvortsov1
    askvortsov1 committed Apr 22, 2021
    Configuration menu
    Copy the full SHA
    e592768 View commit details
    Browse the repository at this point in the history

  13. Simplify DiscussionComposer load

    @askvortsov1
    askvortsov1 committed Apr 22, 2021
    Configuration menu
    Copy the full SHA
    8c87bb2 View commit details
    Browse the repository at this point in the history

  14. Remove unnecessary var

    @askvortsov1
    askvortsov1 committed Apr 22, 2021
    Configuration menu
    Copy the full SHA
    d79089d View commit details
    Browse the repository at this point in the history

Commits on Apr 23, 2021

  1. Load in children on tags page

    @askvortsov1
    askvortsov1 committed Apr 23, 2021
    Configuration menu
    Copy the full SHA
    33e517f View commit details
    Browse the repository at this point in the history

  2. Fixes 

    - Keep json_decoded api doc as object
- Load in siblings
    @askvortsov1
    askvortsov1 committed Apr 23, 2021
    Configuration menu
    Copy the full SHA
    3a6837c View commit details
    Browse the repository at this point in the history

Commits on Apr 24, 2021

  1. Load children.parent relation for child tags

    @askvortsov1
    askvortsov1 committed Apr 24, 2021
    Configuration menu
    Copy the full SHA
    720e530 View commit details
    Browse the repository at this point in the history

  2. Fix jumpy animation

    @askvortsov1
    askvortsov1 committed Apr 24, 2021
    Configuration menu
    Copy the full SHA
    cc488e2 View commit details
    Browse the repository at this point in the history

  3. Fix tag undefined

    @askvortsov1
    askvortsov1 committed Apr 24, 2021
    Configuration menu
    Copy the full SHA
    0738259 View commit details
    Browse the repository at this point in the history

  4. Fix null children

    @askvortsov1
    askvortsov1 committed Apr 24, 2021
    Configuration menu
    Copy the full SHA
    42b7399 View commit details
    Browse the repository at this point in the history

Commits on May 4, 2021

  1. Update src/LoadForumTagsRelationship.php 

    Co-authored-by: Sami Mazouz <[email protected]>
    @askvortsov1 @SychO9
    askvortsov1 and SychO9 authored May 4, 2021
    Configuration menu
    Copy the full SHA
    750acc8 View commit details
    Browse the repository at this point in the history

  2. Eager load when appropriate

    @askvortsov1
    askvortsov1 committed May 4, 2021
    Configuration menu
    Copy the full SHA
    23c9a8c View commit details
    Browse the repository at this point in the history