Added title and description meta tags #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
askvortsov1
changed the title
|
This is a very decent PR @askvortsov1 well done! |
franzliedke
reviewed
Feb 28, 2020
askvortsov1
force-pushed
the
as/add_title_and_meta_cleanup
branch
from
db942e3
to
7f10674
Compare
|
Addressed |
|
Thank you! |
|
@franzliedke the accompanying flarum/lang-english#154 still needs to be merged |
|
I know. I will change the keys, though. |
franzliedke
added a commit
to flarum/lang-english
that referenced
this pull request
Mar 6, 2020
Closes #154. Refs flarum/tags#72.
askvortsov1
pushed a commit
to flarum/lang-english
that referenced
this pull request
Mar 11, 2022
Closes #154. Refs flarum/tags#72.
askvortsov1
added a commit
that referenced
this pull request
Mar 11, 2022
askvortsov1
pushed a commit
to flarum/lang-english
that referenced
this pull request
May 10, 2022
Closes #154. Refs flarum/tags#72.
askvortsov1
added a commit
that referenced
this pull request
May 10, 2022
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modified code to set the meta "title" attribute based on the current page's tag, or to "Tags" (translatable) for pages related to the tags extension.