chore: graceful failure from extend/override errors #4134
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request:
Reduces forum crashes by gracefully failing from extension logic errors within
extend
andoverride
callbacks.Before
![Screenshot from 2024-12-07 16-21-06](https://private-user-images.githubusercontent.com/20267363/393527396-87abe557-5008-415c-b8be-f5e0c98e540b.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkwMjA2MzQsIm5iZiI6MTczOTAyMDMzNCwicGF0aCI6Ii8yMDI2NzM2My8zOTM1MjczOTYtODdhYmU1NTctNTAwOC00MTVjLWI4YmUtZjVlMGM5OGU1NDBiLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMDglMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjA4VDEzMTIxNFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWM0OTNmMThhNmFjYTMyODg3ZmIzYjMwYTZkZTcxZjViYWI3NzZhZWRjMjI2NWQ0MTM1MjQzMDlkMTQ2Nzk4OTUmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.61D4wOtM4fJILKkBF7_pLxZDJ--ejCnvBFT1qXUu8FE)
After
![Screenshot from 2024-12-07 16-21-22](https://private-user-images.githubusercontent.com/20267363/393527416-05095396-0187-426c-bb9c-19d1c43908a7.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkwMjA2MzQsIm5iZiI6MTczOTAyMDMzNCwicGF0aCI6Ii8yMDI2NzM2My8zOTM1Mjc0MTYtMDUwOTUzOTYtMDE4Ny00MjZjLWJiOWMtMTlkMWM0MzkwOGE3LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMDglMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjA4VDEzMTIxNFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPThkMjk0M2U2ZDVhYWYyZTAyZTRhMmZmMTIxOWY0MDk1OTkzNTg0ZTQxY2NkZDkwYzBkM2Y2YjU4MDU1YmJhNzMmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.uxjGUFrOLrtagV2H9OJfTR7pfPjhipusTWI6_vnfLqo)
Necessity
Confirmed
composer test
).Required changes: