Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(mentions): cannot use mentionables extender #3849

Merged
merged 3 commits into from
Jul 1, 2023
Merged

fix(mentions): cannot use mentionables extender #3849

merged 3 commits into from
Jul 1, 2023

Conversation

SychO9
Copy link
Member

@SychO9 SychO9 commented Jun 30, 2023

Changes proposed in this pull request:

  • Fixes the fact you can't use the newly introduced mentionables frontend extender in 1.8

Reviewers should focus on:

Screenshot

Necessity

  • Has the problem that is being solved here been clearly explained?
  • If applicable, have various options for solving this problem been considered?
  • For core PRs, does this need to be in core, or could it be in an extension?
  • Are we willing to maintain this for years / potentially forever?

Confirmed

  • Frontend changes: tested on a local Flarum installation.
  • Backend changes: tests are green (run composer test).
  • Core developer confirmed locally this works as intended.
  • Tests have been added, or are not appropriate here.

@SychO9 SychO9 requested a review from a team as a code owner June 30, 2023 20:52
@SychO9 SychO9 changed the title Sm/mentionables extender no work fix(mentions): cannot use mentionables extender Jun 30, 2023
@SychO9 SychO9 added this to the 1.8.2 milestone Jun 30, 2023
@SychO9 SychO9 merged commit 8f75139 into 1.x Jul 1, 2023
@SychO9 SychO9 deleted the sm/mentionables-extender-no-work branch July 1, 2023 16:47
SychO9 added a commit that referenced this pull request Jul 4, 2023
@SychO9
fix(mentions): cannot use mentionables extender (#3849)
d2a6329
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imorland imorland imorland approved these changes

Assignees
No one assigned
Labels
type/bug type/extensibility
Projects
None yet
Milestone
1.8.2
Development

Successfully merging this pull request may close these issues.
3 participants
@SychO9 @imorland @StyleCIBot