Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: upgrade to mithril 2.2 #3831

Merged
merged 1 commit into from
Jun 15, 2023
Merged

chore: upgrade to mithril 2.2 #3831

merged 1 commit into from
Jun 15, 2023

Conversation

SychO9
Copy link
Member

@SychO9 SychO9 commented May 31, 2023 •
edited
Loading

Changes proposed in this pull request:
Upgrades to mithril 2.2

Reviewers should focus on:

  • Found one breaking change, a vnode with simple text no longer has the text in vnode.text, it is now a child node with the # tag. Any direct access to vnode.text should be replaced in extensions with using the extractText utility.

Necessity

  • Has the problem that is being solved here been clearly explained?
  • If applicable, have various options for solving this problem been considered?
  • For core PRs, does this need to be in core, or could it be in an extension?
  • Are we willing to maintain this for years / potentially forever?

Confirmed

  • Frontend changes: tested on a local Flarum installation.
  • Backend changes: tests are green (run composer test).
  • Core developer confirmed locally this works as intended.
  • Tests have been added, or are not appropriate here.

References

@SychO9 SychO9 added dependencies Pull requests that update a dependency file breaking-changes extension-breaking javascript Pull requests that update Javascript code labels May 31, 2023
@SychO9 SychO9 requested a review from a team as a code owner May 31, 2023 10:49
imorland
imorland approved these changes Jun 14, 2023
View reviewed changes
Copy link
Member

@imorland imorland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks all good to me 👍

@SychO9 SychO9 added this to the 2.0 milestone Jun 15, 2023
@SychO9 SychO9 merged commit 11b4a81 into 2.x Jun 15, 2023
@SychO9 SychO9 deleted the sm/mithril-2.2-upgrade branch June 15, 2023 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imorland imorland imorland approved these changes

Assignees
No one assigned
Labels
breaking-changes dependencies Pull requests that update a dependency file extension-breaking javascript Pull requests that update Javascript code
Projects
None yet
Milestone
2.0.0-beta.1
Development

Successfully merging this pull request may close these issues.
2 participants
@SychO9 @imorland