fix: groupmentions have poor contrast on some backgrounds #3672
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First noticed on
discuss
today, some group colors present poor text contrast.For the record, I would not have been able to complete this without the help of @davwheat - thank you David!
Changes proposed in this pull request:
Utilize the
yiq
helper recently introduced to add either a--light
or--dark
classReviewers should focus on:
Screenshot
Before:
After:
Necessity
Confirmed
composer test
).Required changes: