Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: groupmentions have poor contrast on some backgrounds #3672

Merged
merged 8 commits into from
Nov 7, 2022

Conversation

imorland
Copy link
Member

@imorland imorland commented Nov 7, 2022

First noticed on discuss today, some group colors present poor text contrast.

For the record, I would not have been able to complete this without the help of @davwheat - thank you David!

Changes proposed in this pull request:
Utilize the yiq helper recently introduced to add either a --light or --dark class

Reviewers should focus on:

Screenshot
Before:
image
image

After:
image
image

Necessity

  • Has the problem that is being solved here been clearly explained?
  • If applicable, have various options for solving this problem been considered?
  • For core PRs, does this need to be in core, or could it be in an extension?
  • Are we willing to maintain this for years / potentially forever?

Confirmed

  • Frontend changes: tested on a local Flarum installation.
  • Backend changes: tests are green (run composer test).
  • Core developer confirmed locally this works as intended.
  • Tests have been added, or are not appropriate here.

Required changes:

  • Related documentation PR: (Remove if irrelevant)
  • Related core extension PRs: (Remove if irrelevant)

@imorland imorland requested a review from a team as a code owner November 7, 2022 14:02
@imorland imorland self-assigned this Nov 7, 2022
@imorland imorland added this to the 1.6 milestone Nov 7, 2022
@luceos luceos merged commit c98e6ba into main Nov 7, 2022
@luceos luceos deleted the im/groupmention-contrast-fix branch November 7, 2022 15:49
@luceos luceos mentioned this pull request Nov 10, 2022
@Ornanovitch
Copy link
Contributor

I'm so glad this yiq helper already helps! ♥️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants