Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[statistics] fix: add missing last period to custom date ranges #3661

Merged
merged 3 commits into from
Nov 6, 2022

Conversation

davwheat
Copy link
Member

@davwheat davwheat commented Oct 30, 2022

Fixes a bug introduced with #3622.

Changes proposed in this pull request:

  • adds support for "last period" for custom date ranges
  • fix incorrect offset for previous date ranges

Reviewers should focus on:

  • N/A

Screenshot

Necessity

  • Has the problem that is being solved here been clearly explained?
  • If applicable, have various options for solving this problem been considered?
  • For core PRs, does this need to be in core, or could it be in an extension?
  • Are we willing to maintain this for years / potentially forever?

Confirmed

  • Frontend changes: tested on a local Flarum installation.
  • Backend changes: tests are green (run composer test).
  • Core developer confirmed locally this works as intended.
  • Tests have been added, or are not appropriate here.

@davwheat davwheat requested a review from a team as a code owner October 30, 2022 23:35
@davwheat davwheat self-assigned this Oct 30, 2022
@imorland imorland added this to the 1.6 milestone Nov 6, 2022
@imorland imorland changed the title fix: add missing last period to custom date ranges [statistics] fix: add missing last period to custom date ranges Nov 6, 2022
@imorland imorland merged commit 9964ddd into main Nov 6, 2022
@imorland imorland deleted the dw/stats-last-period-custom branch November 6, 2022 18:21
@luceos luceos mentioned this pull request Nov 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants