Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: apply flex for AppearancePage colors input #3651

Merged
merged 1 commit into from
Oct 1, 2022
Merged

fix: apply flex for AppearancePage colors input #3651

merged 1 commit into from
Oct 1, 2022

Conversation

datlechin
Copy link
Contributor

@datlechin datlechin commented Sep 24, 2022

Fixes #0000

Changes proposed in this pull request:

  • Colors input on mobile is broken, apply flex to fix this

Reviewers should focus on:

Screenshot

Before:
Screenshot 2022-09-24 at 12 09 04

After:
Screenshot 2022-09-24 at 12 08 49

Necessity

  • Has the problem that is being solved here been clearly explained?
  • If applicable, have various options for solving this problem been considered?
  • For core PRs, does this need to be in core, or could it be in an extension?
  • Are we willing to maintain this for years / potentially forever?

Confirmed

  • Frontend changes: tested on a local Flarum installation.
  • Backend changes: tests are green (run composer test).
  • Core developer confirmed locally this works as intended.
  • Tests have been added, or are not appropriate here.

Required changes:

  • Related documentation PR: (Remove if irrelevant)
  • Related core extension PRs: (Remove if irrelevant)

@datlechin datlechin requested a review from a team as a code owner September 24, 2022 05:10
Copy link
Member

@davwheat davwheat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't tested, but could you show a screenshot of how this looks on desktop with flex? I have a feeling something might mess that up, but I hope I'm wrong.

@datlechin
Copy link
Contributor Author

@davwheat same as before, on desktop no UI change

Screen.Recording.2022-09-24.at.13.00.40.mov

@datlechin datlechin requested a review from davwheat September 24, 2022 06:01
@luceos luceos merged commit d33f1ab into flarum:main Oct 1, 2022
@luceos
Copy link
Member

luceos commented Oct 1, 2022

Thanks @datlechin 💪

@luceos luceos added this to the 1.6 milestone Oct 1, 2022
@luceos luceos mentioned this pull request Nov 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants