Fix missed escape sequences at /src/CmakeLists.txt #3354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmahmoudian
approved these changes
Oct 1, 2023
|
Thanks for the PR. Looks good to me. Let's wait for another Dev's approval |
|
Hi @mmahmoudian I also noticed that build instruction is a little bit outdated and may seem to be confusing in some way. Since root CMakeLists has implicitly specified Qt5_DIR variable on its own we don't need to provide this variable as command line parameter after |
veracioux
approved these changes
Oct 9, 2023
panpuchkov
pushed a commit
to namecheap/flameshot
that referenced
this pull request
Dec 22, 2023
(cherry picked from commit fe0d87f)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello
I found out that when the project repository is cloned to a path containing spaces, it leads to a Cmake configuration error.
The problem occurs only on MacOS