Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add no-inline option #127

Merged
merged 4 commits into from
Mar 23, 2021
Merged

Add no-inline option #127

merged 4 commits into from
Mar 23, 2021

Conversation

inteon
Copy link
Contributor

@inteon inteon commented Feb 24, 2021

Fixes #74 and #126

This is how to use it:

flamegraph --no-inline -o flamegraph.svg [COMMAND]

@djc
Copy link
Contributor

djc commented Mar 2, 2021

Thanks for working on this!

Would it be useful to add some hints to the README about how/when to use this?

Additionally I'd like to error out when this option is used on macOS (that is, when the backend doesn't support the option).

@djc djc mentioned this pull request Mar 2, 2021
@Licenser
Copy link
Contributor

Licenser commented Mar 4, 2021

<3 this would be lovely to have!

@djc
Copy link
Contributor

djc commented Mar 6, 2021

@bors r+

@inteon
Copy link
Contributor Author

inteon commented Mar 6, 2021

@djc I added the requested changes. As I don't use macOS, I was not able to test that yet.

@inteon
Copy link
Contributor Author

inteon commented Mar 23, 2021

@djc @Licenser Can this be merged?

@djc
Copy link
Contributor

djc commented Mar 23, 2021

bors r+

@bors
Copy link
Contributor

bors bot commented Mar 23, 2021

@bors bors bot merged commit ee462f2 into flamegraph-rs:master Mar 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

addr2line taking an exorbitant amount of time
3 participants