-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rework attributes #155
Merged
Merged
Rework attributes #155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dobbersc
requested changes
Apr 10, 2023
I tried my best to review this PR. But be aware that I do not totally understand everything that has been changed. |
Co-authored-by: Conrad Dobberstein <[email protected]>
dobbersc
reviewed
Apr 11, 2023
This was referenced Apr 11, 2023
Merged
Co-authored-by: Conrad Dobberstein <[email protected]>
dobbersc
reviewed
Apr 12, 2023
Co-authored-by: Conrad Dobberstein <[email protected]>
Co-authored-by: Conrad Dobberstein <[email protected]>
Co-authored-by: Conrad Dobberstein <[email protected]>
dobbersc
approved these changes
Apr 12, 2023
Ah there is one parameter left to rename |
dobbersc
reviewed
Apr 12, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should only be merged after #148 and with the proper settings. Currently this commits into #148
This PR addresses issues raised in #138.
It does so by adding a parameter
supported
to the attribute decorator.True
(default), the decorated attribute is validated against the attribute_guidelines (name, annotation),False
the attribute is excluded from those tests.This also does a major refactor on the article class. We have to so article supports unsupported attributes.
Article
, but only those supported will be actual fields ofArticle
. See the following exampleYou can now access all attributes with dot notation (
article.body, article.key_notes
) but only those in the guidelines will have auto-completion, and providing no annotation forkey_notes
here won't raise any error duuring testing.Article
structure and inheritance.