fix some typing

flairNLP · Jan 31, 2025 · 087b74e · 087b74e
1 parent 79aa337
commit 087b74e
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 5 deletions.
diff --git a/flair/embeddings/document.py b/flair/embeddings/document.py
@@ -691,10 +691,9 @@ def _add_embeddings_internal(self, sentences: list[Sentence]):
 
         lengths: list[int] = [len(sentence.tokens) for sentence in sentences]
         padding_length: int = max(max(lengths), self.min_sequence_length)
-
         pre_allocated_zero_tensor = torch.zeros(
             self.embeddings.embedding_length * padding_length,
-            dtype=self.convs[0].weight.dtype,
+            dtype=cast(torch.nn.Conv1d, self.convs[0]).weight.dtype,
             device=flair.device,
         )
 

diff --git a/flair/embeddings/token.py b/flair/embeddings/token.py
@@ -1466,7 +1466,7 @@ def _add_embeddings_internal(self, sentences: list[Sentence]) -> list[Sentence]:
             word = token.text if self.field is None else token.get_label(self.field).value
 
             if word.strip() == "":
-                ids = [self.spm.vocab_size(), self.embedder.spm.vocab_size()]
+                ids = [self.spm.vocab_size(), self.spm.vocab_size()]
             else:
                 if self.do_preproc:
                     word = self._preprocess(word)

diff --git a/flair/models/sequence_tagger_model.py b/flair/models/sequence_tagger_model.py
@@ -862,8 +862,8 @@ def push_to_hub(
             self.save(local_model_path)
 
             # Determine if model card already exists
-            info = model_info(repo_id, use_auth_token=token)
-            write_readme = all(f.rfilename != "README.md" for f in info.siblings)
+            info = model_info(repo_id, token=token)
+            write_readme = info.siblings is None or all(f.rfilename != "README.md" for f in info.siblings)
 
             # Generate and save model card
             if write_readme: