Skip to content

[Advanced Compiler]Add TE.geglu&dgeglu #1056

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 13 commits into
base: master
Choose a base branch
from
Open

[Advanced Compiler]Add TE.geglu&dgeglu #1056

wants to merge 13 commits into from

Conversation

@AdvancedCompiler
Copy link
Contributor

@AdvancedCompiler AdvancedCompiler commented Nov 14, 2025

PR Category

Operator

Type of Change

New Featur

Description

Add transformer_engine_torch.geglu&transformer_engine_torch.dgeglu

Issue

Progress

  • Change is properly reviewed (1 reviewer required, 2 recommended).
  • Change is responded to an issue.
  • Change is fully covered by a UT.

Performance

@CLAassistant
Copy link

CLAassistant commented Nov 14, 2025 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@0x45f
Copy link
Collaborator

0x45f commented Nov 17, 2025

plz fix pre-commit ci

@0x45f
Copy link
Collaborator

0x45f commented Nov 17, 2025

The flag-gems-test-on-hopper CI has already installed transformer_engine version 2.3.0+5de3e14, but this CI failed，plz fix error

@0x45f 0x45f mentioned this pull request Nov 17, 2025
Open
3 tasks
@logic2c
Copy link

logic2c commented Nov 17, 2025

The flag-gems-test-on-hopper CI has already installed transformer_engine version 2.3.0+5de3e14, but this CI failed，plz fix error

a small error was fixed, but actually the big problem is the version of transformer_engine, please use 2.8.0

@0x45f
Copy link
Collaborator

0x45f commented Nov 18, 2025

The flag-gems-test-on-hopper CI has already installed transformer_engine version 2.3.0+5de3e14, but this CI failed，plz fix error

a small error was fixed, but actually the big problem is the version of transformer_engine, please use 2.8.0

I have fixed CI, thx

0x45f
0x45f reviewed Nov 19, 2025
View reviewed changes
Copy link
Collaborator

@0x45f 0x45f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove xx-checkpoint.py files

@0x45f 0x45f mentioned this pull request Nov 26, 2025
Open
3 tasks
0x45f
0x45f reviewed Dec 2, 2025
View reviewed changes
Copy link
Collaborator

@0x45f 0x45f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add the performance test results

@0x45f 0x45f self-assigned this Dec 2, 2025
@logic2c
Copy link

logic2c commented Dec 2, 2025

Please add the performance test results

image-10 image-11 image-12 image-13 image-14 image-15

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@0x45f 0x45f 0x45f left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@0x45f 0x45f

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@AdvancedCompiler @CLAassistant @0x45f @logic2c