Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Yandex Turbopages + tabs #10

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Rainbow-Spike
Copy link

  1. Tabulations
  2. Compatibility with requirements of Yandex Turbopages mobile service https://tech.yandex.com/turbo/
    New strings ## 41, 131-133, 139-140

My case https://comicslate.org/feed.php?onlynewpages=1
It has no errors in their feed debug tool http://screenshot.ru/6becfb15bd89f75d21395112dd297af7.png

1. Tabulations
2. Support for Yandex Turbopages mobile service https://tech.yandex.com/turbo/
New strings ## 41, 131-133, 139-140

My case https://comicslate.org/feed.php?onlynewpages=1
It has no errors in their feed debug tool http://screenshot.ru/6becfb15bd89f75d21395112dd297af7.png
@flack
Copy link
Owner

flack commented Sep 2, 2020

Hello & thanks for the PR!

Some notes:

If anything wrt to whitespace is changed, it should probably be done globally in the entire project, not just in one file

  • right now the Yandex data gets added unconditionally, i.e. every user of this class will add the Yandex attributes, even if they never use it. Wouldn't it be better to make this configurable (e.g. by having a method enableYandexTurbo() or similar)?

  • it has been a while since I've looked at the turbo stuff, but if I remember correctly, bot all tags are allowed inside of <turbo:content>. So shouldn't there be a way for users to set a different value for <turbo:content> and <description>?

@Rainbow-Spike
Copy link
Author

  • I'm a stranger here, so if spaces are not pleasing, I do not mind. I have already listed the useful string numbers - ## 41, 131-133, 139-140
  • the idea of a switch for Yandex sounds as good, as idea about a difference in content customization too
  • I inserted "…" as a substitute for the error presented by Yandex - the content inside CDATA-tag should not be empty

so you feel free to close this pull and make you vision

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants