[Mamba2] Post Merge Fixes - norm_before_gate and generation with inputs_embeds #57
Merged
yzhangcs merged 1 commit intofla-org:mainfrom Sep 5, 2024
Merged
Conversation
Member
|
Thank you :D |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since the implementation seems like a mirror to the one of the transformers repo, I thought I'd share some fixes post-merge that have been applied:
inputs_embedshas been broken, ref. Fix: Mamba2 generation mismatch between input_ids and inputs_embeds huggingface/transformers#32694norm_before_gateflag which causes misaligned training when using the completely fused kernel, ref. Fix: Mamba2norm_before_gateusage huggingface/transformers#32686Cool repo btw :)