[Gated DeltaNet] fix gdn kernel bugs on h100 when vdim=64#256
[Gated DeltaNet] fix gdn kernel bugs on h100 when vdim=64#256yzhangcs merged 2 commits intofla-org:mainfrom
Conversation
WalkthroughThe pull request modifies two functions in the Changes
Possibly related PRs
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (2)
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
@kugwzk how about |
|
We are moving towards Triton 3.3.0 adaptation, and blindly reducing wraps will significantly reduce the performance of other platforms. I will pay a close attention on it, and maybe we can give some workaround solutions. It seems that still failed on H100 with yesterday triton3.3.0 nightly: |
* [Gated DeltaNet] Fix gdn kernel bugs on h100 when vdim=64 (#256) * fix h100 erros(part1) * fix * fix2 * fix * fix * update ci pipeline * pre-commit * add ci proxy * remove https to use hosts * fix nightly ci * f * [README] Fix footnote bugs * enhance * pre-commit * Delete unnecessary lines * remove magic numer * remove hardcode proxy * remove unnecessary seq_len in test * Refactor code and variable naming * fffff * revert * Change item order in Enum * update * add comments for intel grf_mode * use `check_shared_mem()` instead of `device_capacity` * pre-commit * fix * skip tests for 4090 and use triton 3.3.0 for h100 * skip * update faq --------- Co-authored-by: Yu Zhang <yzhang.cs@outlook.com>

Summary by CodeRabbit