Build artificial samples with scons instead of make #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enkelmann
suggested changes
Apr 5, 2019
There was a problem hiding this comment.
The code looks much better than the old makefile!
But when running scons I get an error
scons: Reading SConscript files ...
Building for architecture x64
AttributeError: 'module' object has no attribute 'which':
File "[...]/cwe_checker/test/artificial_samples/SConstruct", line 71:
build_c(arch)
File "[...]/cwe_checker/test/artificial_samples/SConstruct", line 42:
if shutil.which(c_compilers[arch]) is not None:
so right now scons doesn't build anything on my computer.
test/artificial_samples/SConstruct
Outdated
| env = Environment(CC = c_compilers[arch], | ||
| CCFLAGS = c_flags[arch] + optimize(str(p))) | ||
| env.Program('build/%s_%s.out' % (str(p).split('.')[0], arch), 'build/%s' % str(p)) | ||
| # TODO: call execstack -s |
There was a problem hiding this comment.
Do we have a test right now that depends on the call of execstack?
There was a problem hiding this comment.
I believe none, I do not know why it was there in the first place.
|
Scons3 does not work properly on Ubuntu 16.04/18.04, but on current Fedora. So switching to scons2 (pip install --user scons). Now it should compile all binaries. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR exchanges make with scons. This makes building the artificial samples painless!!!