Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix keyring only for hydro #1276

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

eisoku9618
Copy link
Contributor

hope this will solve #1273 #1274 #1275

@fkanehiro
Copy link
Owner

I restarted travis several times but 14 and 15 failed every time.
Is this just due to shortage of computing power or is there any issue to be solved?

@eisoku9618
Copy link
Contributor Author

There seems to be a issue to be solved between latest OpenHRP3 and hironx-ros-bridge.

I tried running the same test with No. 15(TEST_PACKAGE=hironx-ros-bridge USE_SRC_OPENHRP3=true) in my local computer then it failed.
But it passed when I went back a few commits of OpenHRP3 which is used during the test.

I tried to find from which commit the test failed in #1277 using Travis, but I couldn't because of the this limit (50min).

@eisoku9618
Copy link
Contributor Author

I've just noticed that the cause of time overs of No. 14 and No.15 is
that rostest /opt/ros/indigo/share/hironx_ros_bridge/test/test-hironx-ros-bridge-controller.test cannot be finished by some reasons (but I don't know the reasons).

In the latest test which was passed (5 months ago) https://travis-ci.org/fkanehiro/hrpsys-base/builds/485221572, test-hironx-ros-bridge-controller.test can be finished around 10 seconds.

And in this February (3 or 4 months ago), there was a new release of hironx-ros-bridge (version 2.1.1).

So I think this release might be related to No. 14 and No. 15 issue.
cc @k-okada sensei

I would like to try to downgrade hironx-ros-bridge from version 2.1.1 to 2.1.0 following this link http://thr3a.hatenablog.com/entry/20180110/1515593932, but unfortunately it seems impossible because of the recent change of packages.ros.org

image

@orikuma
Copy link
Contributor

orikuma commented Oct 8, 2019

I think test No.14 and 15 fails because HrpsysSeqStateROSBridge and HrpsysJointTrajectoryBridge died by memory corruption. (cf. https://travis-ci.org/fkanehiro/hrpsys-base/jobs/545245166#L11642)
This problem seems to occur when openhrp3 is installed from both apt and src, regardless of the version of ros-indigo-hironx-ros-bridge (No.14 and 15 have USE_SRC_OPENHRP3=true and use hrpsys_ros_bridge for test).

We may need to wait for solving this problem in hrpsys_ros_bridge (although indigo is EOL).
Similar issues were already reported in rtmros_common such as start-jsk/rtmros_common#1064.
It may be also possible to forcely remove ros-indigo-openhrp3 when USE_SRC_OPENHRP3=true as a workaround, but it will require some additional modification (for example, configuration files installed by ros-indigo-hironx-ros-bridge assumes that model files in ros-indigo-openhrp3 are installed in /opt/ros directory) and not be recommended.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants