fix(EventBus): 解决 off 问题

fjc0k · Oct 18, 2021 · 277149e · 277149e
1 parent 0fdf552
commit 277149e
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 1 deletion.
diff --git a/src/utils/EventBus.test.ts b/src/utils/EventBus.test.ts
@@ -1,4 +1,5 @@
 import { EventBus } from './EventBus'
+import { wait } from './wait'
 
 type Events = {
   enter: () => number
@@ -81,6 +82,18 @@ describe('EventBus', () => {
     expect(successCallback2).toBeCalled().toBeCalledTimes(1)
   })
 
+  test('可只订阅一次: bug', async () => {
+    const bus = new EventBus<Events>()
+    const successCallback = jest.fn()
+    const successCallback2 = jest.fn()
+    bus.once('success', successCallback)
+    bus.once('success', successCallback2)
+    await wait(10)
+    bus.emit('success')
+    expect(successCallback).toBeCalled().toBeCalledTimes(1)
+    expect(successCallback2).toBeCalled().toBeCalledTimes(1)
+  })
+
   test('可获取订阅回调结果', () => {
     const bus = new EventBus<Events>()
     const enterCallback = jest.fn().mockImplementation(() => 1)

diff --git a/src/utils/EventBus.ts b/src/utils/EventBus.ts
@@ -163,7 +163,7 @@ export class EventBus<TListeners extends EventBusListeners> {
         : {
             name: eventName,
           }
-    let callbacks = this.callbacks[name] || []
+    let callbacks = (this.callbacks[name] || []).slice()
     if (tag != null) {
       callbacks = callbacks.filter(
         callback =>