Adding options.allowDots (works for node 10.x, 12.x and 14.x) #41

Blagoj5 · 2021-01-23T15:47:36Z

Adding new option/feature, options.allowDots that is used for skipping the sanitization of data that has .(dot). This can be useful for nested document quering for mongoDb: https://docs.mongodb.com/manual/tutorial/query-embedded-documents/

Creating new tests that include the new option

Updating the documentation (README.md) file for the new option

Adressing issue: #36

Adding new option/feature, options.allowDots that is used for skipping the sanitization of data that has .(dot). This can be useful for nested document quering for mongoDb: https://docs.mongodb.com/manual/tutorial/query-embedded-documents/ Creating new tests that include the new option Updating the documentation (README.md) file for the new option Adressing issue: fiznool#36

azu · 2021-03-18T06:54:16Z

Sorry for to delay.
Can you rebase it?

fiznool

Thank you for your contribution! And apologies it has taken so long to get around to reviewing.

There are a whole bunch of whitespace/formatting changes here which makes it hard to determine what has changed, and what hasn't. Please could you resubmit without the formatting changes?

In addition, there are some conflicts with the master branch that need resolving.

Finally, please see the comments below.

index.js

Blagoj5 · 2021-03-22T15:37:44Z

Hi,
Currently i'm unable to change/format the code, because i had a surgery couple days ago and i'm still recovering. However, when i get up i will fix the issues and do another pull request. Also it's my bad that i didn't run any linter to show me the variables where i have let instead of const (in the first version i needed them as let and forgot to return them back to const). Soon, I will make changes to the other things you marked and hopefully it will be alright this time.

fiznool · 2021-03-22T15:53:35Z

Hope you feel better soon 🤕

TheodosiouTh · 2021-05-12T14:04:18Z

Hello @Blagoj5,
I hope you are doing ok.

Can you give an update on the status of this pull request?
I am asking because I need this for a new feature I am building.
If you are unable to finish it I will be happy to take over this PR and complete it.

(cc. @fiznool)

Blagoj5 · 2021-05-12T15:35:45Z

@TheodosiouTh, there are many changes to the code since then, but i should be able to get it done today or tomorrow

TheodosiouTh · 2021-05-12T15:38:19Z

@Blagoj5
Thank you so much for the quick response.
If you need any help I will be happy to help.

Blagoj5 · 2021-05-12T16:24:32Z

@TheodosiouTh, I just commited the final code. You can check it up if you want and recommend me what should i change

@fiznool, when you have time, check the code and warn me if anything needs to be updated

cor1 · 2021-11-08T16:40:12Z

an idea when this will get merged?

azu

LGTM

aria-mdr · 2022-01-11T14:09:51Z

hey all, any update on when this will be merged?

Squashed commit of the following: commit f85e51644ed68a74dd5fbe7a79c17e62e02aed01 Author: Tom Spencer <[email protected]> Date: Fri Jan 14 10:47:41 2022 +0000 Removed unnecessary file commit 059be6ba7fb8a4d6e80147a94b03a064f1a43fcc Merge: 565c1ea 55a16c7 Author: Tom Spencer <[email protected]> Date: Fri Jan 14 10:46:46 2022 +0000 Merge branch 'master' of github.com:Blagoj5/express-mongo-sanitize into Blagoj5-master commit 55a16c7 Merge: 16534f2 9cc5240 Author: Blagoj <[email protected]> Date: Wed May 12 18:22:57 2021 +0200 Merge github.com:fiznool/express-mongo-sanitize commit 16534f2 Author: Blagoj <[email protected]> Date: Wed May 12 17:07:35 2021 +0200 Clean code and fix tests commit 565c1ea Author: Tom Spencer <[email protected]> Date: Tue May 11 16:47:57 2021 +0100 Bump package version to 2.1.0 commit 05e39bb Author: Blagoj <[email protected]> Date: Sat Jan 23 16:40:25 2021 +0100 feat: Adding new options (options.allowDots) Adding new option/feature, options.allowDots that is used for skipping the sanitization of data that has .(dot). This can be useful for nested document quering for mongoDb: https://docs.mongodb.com/manual/tutorial/query-embedded-documents/ Creating new tests that include the new option Updating the documentation (README.md) file for the new option Adressing issue: #36 commit 287075b Author: Blagoj <[email protected]> Date: Sat Jan 23 16:38:15 2021 +0100 feat: Adding new options (options.allowDots) Adding new option/feature, options.allowDots that is used for skipping the sanitization of data that has .(dot). This can be useful for nested document quering for mongoDb: https://docs.mongodb.com/manual/tutorial/query-embedded-documents/ Creating new tests that include the new option Updating the documentation (README.md) file for the new option Adressing issue: #36 commit aec9249 Author: Blagoj <[email protected]> Date: Sat Jan 23 16:17:53 2021 +0100 feat: Adding new options (options.allowDots) Adding new option/feature, options.allowDots that is used for skipping the sanitization of data that has .(dot). This can be useful for nested document quering for mongoDb: https://docs.mongodb.com/manual/tutorial/query-embedded-documents/ Creating new tests that include the new option Updating the documentation (README.md) file for the new option Adressing issue: #36

fiznool · 2022-01-14T10:51:33Z

Closed via 32c997b

fiznool · 2022-01-14T11:14:08Z

Published as v2.2.0.

Thanks to everyone for your contributions, and your patience - apologies it has taken so long to get this merged in.

Blagoj5 added 3 commits January 23, 2021 16:17

azu mentioned this pull request Mar 18, 2021

feat: add onSanitize and dryRun option #39

Merged

fiznool requested changes Mar 18, 2021

View reviewed changes

index.js Outdated Show resolved Hide resolved

index.js Outdated Show resolved Hide resolved

index.js Outdated Show resolved Hide resolved

index.js Outdated Show resolved Hide resolved

index.js Outdated Show resolved Hide resolved

index.js Outdated Show resolved Hide resolved

Clean code and fix tests

16534f2

Merge github.com:fiznool/express-mongo-sanitize

55a16c7

azu approved these changes Dec 21, 2021

View reviewed changes

fiznool closed this Jan 14, 2022

Emmanuel97423 mentioned this pull request Sep 7, 2024

[Snyk] Upgrade: bcrypt, body-parser, dotenv, express, express-mongo-sanitize, express-rate-limit, express-session, helmet, mongoose, multer, nodemon, password-validator Emmanuel97423/So_Peckoko_api#129

Open

sahilpawar58 mentioned this pull request Sep 9, 2024

[Snyk] Upgrade: bcrypt, cookie-parser, ejs, express, express-mongo-sanitize, express-rate-limit, mongoose, multer, validator, xss-clean sahilpawar58/Civil-Project#49

Open

LucileGombert mentioned this pull request Sep 13, 2024

[Snyk] Upgrade: bcrypt, body-parser, crypto-js, express, express-mongo-sanitize, helmet, maskdata, mongoose, multer, password-validator LucileGombert/SoPekocko#309

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adding options.allowDots (works for node 10.x, 12.x and 14.x) #41

Adding options.allowDots (works for node 10.x, 12.x and 14.x) #41

Blagoj5 commented Jan 23, 2021

azu commented Mar 18, 2021

fiznool left a comment

Blagoj5 commented Mar 22, 2021

fiznool commented Mar 22, 2021

TheodosiouTh commented May 12, 2021 •

edited

Loading

Blagoj5 commented May 12, 2021

TheodosiouTh commented May 12, 2021

Blagoj5 commented May 12, 2021 •

edited

Loading

cor1 commented Nov 8, 2021

azu left a comment

aria-mdr commented Jan 11, 2022

fiznool commented Jan 14, 2022

fiznool commented Jan 14, 2022

Adding options.allowDots (works for node 10.x, 12.x and 14.x) #41

Adding options.allowDots (works for node 10.x, 12.x and 14.x) #41

Conversation

Blagoj5 commented Jan 23, 2021

azu commented Mar 18, 2021

fiznool left a comment

Choose a reason for hiding this comment

Blagoj5 commented Mar 22, 2021

fiznool commented Mar 22, 2021

TheodosiouTh commented May 12, 2021 • edited Loading

Blagoj5 commented May 12, 2021

TheodosiouTh commented May 12, 2021

Blagoj5 commented May 12, 2021 • edited Loading

cor1 commented Nov 8, 2021

azu left a comment

Choose a reason for hiding this comment

aria-mdr commented Jan 11, 2022

fiznool commented Jan 14, 2022

fiznool commented Jan 14, 2022

TheodosiouTh commented May 12, 2021 •

edited

Loading

Blagoj5 commented May 12, 2021 •

edited

Loading